Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-05 Thread Eduardo Habkost
On Wed, Dec 05, 2018 at 03:02:45PM +0100, Luc Michel wrote: > On 12/4/18 8:45 PM, Eduardo Habkost wrote: > > On Tue, Dec 04, 2018 at 07:16:39PM +, Peter Maydell wrote: > >> On Tue, 4 Dec 2018 at 19:05, Eduardo Habkost wrote: > >>> On Tue, Dec 04, 2018 at 06:24:19PM +, Peter Maydell wrote:

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-05 Thread Luc Michel
On 12/4/18 8:45 PM, Eduardo Habkost wrote: > On Tue, Dec 04, 2018 at 07:16:39PM +, Peter Maydell wrote: >> On Tue, 4 Dec 2018 at 19:05, Eduardo Habkost wrote: >>> On Tue, Dec 04, 2018 at 06:24:19PM +, Peter Maydell wrote: A cluster is a group of CPUs which are all identical and have >

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-05 Thread Luc Michel
On 12/4/18 7:06 PM, Eduardo Habkost wrote: > On Mon, Dec 03, 2018 at 03:09:14PM +0100, Luc Michel wrote: >> >> >> On 12/3/18 12:23 PM, Peter Maydell wrote: >>> On Mon, 3 Dec 2018 at 11:21, Luc Michel wrote: On 11/30/18 5:52 PM, Peter Maydell wrote: > Luc: what are the requirements on

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-05 Thread Luc Michel
On 12/4/18 7:24 PM, Peter Maydell wrote: > On Tue, 4 Dec 2018 at 18:06, Eduardo Habkost wrote: >> In either case, I'm still missing a clear description of what a >> cluster is supposed to represent, exactly (see my previous reply >> on this thread). > > Here's my attempt: > > A cluster is a grou

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-04 Thread Eduardo Habkost
On Tue, Dec 04, 2018 at 07:16:39PM +, Peter Maydell wrote: > On Tue, 4 Dec 2018 at 19:05, Eduardo Habkost wrote: > > On Tue, Dec 04, 2018 at 06:24:19PM +, Peter Maydell wrote: > > > A cluster is a group of CPUs which are all identical and have > > > the same view of the rest of the system.

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-04 Thread Peter Maydell
On Tue, 4 Dec 2018 at 19:05, Eduardo Habkost wrote: > On Tue, Dec 04, 2018 at 06:24:19PM +, Peter Maydell wrote: > > A cluster is a group of CPUs which are all identical and have > > the same view of the rest of the system. > With that definition in mind, why can't QEMU cluster CPUs > automat

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-04 Thread Eduardo Habkost
On Tue, Dec 04, 2018 at 06:24:19PM +, Peter Maydell wrote: > On Tue, 4 Dec 2018 at 18:06, Eduardo Habkost wrote: > > In either case, I'm still missing a clear description of what a > > cluster is supposed to represent, exactly (see my previous reply > > on this thread). > > Here's my attempt:

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-04 Thread Peter Maydell
On Tue, 4 Dec 2018 at 18:06, Eduardo Habkost wrote: > In either case, I'm still missing a clear description of what a > cluster is supposed to represent, exactly (see my previous reply > on this thread). Here's my attempt: A cluster is a group of CPUs which are all identical and have the same vi

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-04 Thread Eduardo Habkost
On Mon, Dec 03, 2018 at 03:09:14PM +0100, Luc Michel wrote: > > > On 12/3/18 12:23 PM, Peter Maydell wrote: > > On Mon, 3 Dec 2018 at 11:21, Luc Michel wrote: > >> > >> On 11/30/18 5:52 PM, Peter Maydell wrote: > >>> Luc: what are the requirements on boards using CPU cluster > >>> objects? I ass

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-03 Thread Luc Michel
On 12/3/18 12:23 PM, Peter Maydell wrote: > On Mon, 3 Dec 2018 at 11:21, Luc Michel wrote: >> >> On 11/30/18 5:52 PM, Peter Maydell wrote: >>> Luc: what are the requirements on boards using CPU cluster >>> objects? I assume these are both OK: >>> * does not use cluster objects at all >>>(t

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-03 Thread Peter Maydell
On Mon, 3 Dec 2018 at 11:21, Luc Michel wrote: > > On 11/30/18 5:52 PM, Peter Maydell wrote: > > Luc: what are the requirements on boards using CPU cluster > > objects? I assume these are both OK: > > * does not use cluster objects at all > >(the gdbstub puts all the CPUs in one process?) > Y

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-12-03 Thread Luc Michel
On 11/30/18 5:52 PM, Peter Maydell wrote: > On Mon, 26 Nov 2018 at 13:27, Eduardo Habkost wrote: >> >> On Sun, Nov 25, 2018 at 10:27:04PM +0100, Philippe Mathieu-Daudé wrote: >>> Hi Eduardo, >>> >>> On 23/11/18 19:10, Eduardo Habkost wrote: If you really want to do this and assign cluster_id

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-30 Thread Eduardo Habkost
On Fri, Nov 30, 2018 at 04:52:31PM +, Peter Maydell wrote: > On Mon, 26 Nov 2018 at 13:27, Eduardo Habkost wrote: > > > > On Sun, Nov 25, 2018 at 10:27:04PM +0100, Philippe Mathieu-Daudé wrote: > > > Hi Eduardo, > > > > > > On 23/11/18 19:10, Eduardo Habkost wrote: > > > > If you really want t

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-30 Thread Peter Maydell
On Mon, 26 Nov 2018 at 13:27, Eduardo Habkost wrote: > > On Sun, Nov 25, 2018 at 10:27:04PM +0100, Philippe Mathieu-Daudé wrote: > > Hi Eduardo, > > > > On 23/11/18 19:10, Eduardo Habkost wrote: > > > If you really want to do this and assign cluster_id > > > automatically, please do it on realize,

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-26 Thread Eduardo Habkost
On Sun, Nov 25, 2018 at 10:27:04PM +0100, Philippe Mathieu-Daudé wrote: > Hi Eduardo, > > On 23/11/18 19:10, Eduardo Habkost wrote: > > Hi, > > > > Sorry for not reviewing this series earlier. I just stumbled > > upon this part of the code: > > > > On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-25 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 23/11/18 19:10, Eduardo Habkost wrote: > Hi, > > Sorry for not reviewing this series earlier. I just stumbled > upon this part of the code: > > On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc Michel wrote: >> This commit adds the cpu-cluster type. It aims at gathering CPUs from >>

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-23 Thread Eduardo Habkost
On Fri, Nov 23, 2018 at 06:53:07PM +, Peter Maydell wrote: > On Fri, 23 Nov 2018 at 18:24, Eduardo Habkost wrote: > > > > On Fri, Nov 23, 2018 at 06:14:28PM +, Peter Maydell wrote: > > > One thing I would like to do with this new "cpu cluster" > > > concept is to use it to handle a problem

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-23 Thread Peter Maydell
On Fri, 23 Nov 2018 at 18:24, Eduardo Habkost wrote: > > On Fri, Nov 23, 2018 at 06:14:28PM +, Peter Maydell wrote: > > One thing I would like to do with this new "cpu cluster" > > concept is to use it to handle a problem we have at the > > moment with TCG, where we assume all CPUs have the sa

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-23 Thread Peter Maydell
On Fri, 23 Nov 2018 at 18:11, Eduardo Habkost wrote: > On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc Michel wrote: > > This commit adds the cpu-cluster type. It aims at gathering CPUs from > > the same cluster in a machine. > > > > For now it only has a `cluster-id` property. > > > > Signed-off-by

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-23 Thread Eduardo Habkost
On Fri, Nov 23, 2018 at 06:14:28PM +, Peter Maydell wrote: > On Fri, 23 Nov 2018 at 18:11, Eduardo Habkost wrote: > > On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc Michel wrote: > > > This commit adds the cpu-cluster type. It aims at gathering CPUs from > > > the same cluster in a machine. > >

Re: [Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-23 Thread Eduardo Habkost
Hi, Sorry for not reviewing this series earlier. I just stumbled upon this part of the code: On Fri, Nov 23, 2018 at 10:17:14AM +0100, Luc Michel wrote: > This commit adds the cpu-cluster type. It aims at gathering CPUs from > the same cluster in a machine. > > For now it only has a `cluster-id

[Qemu-devel] [PATCH v7 01/16] hw/cpu: introduce CPU clusters

2018-11-23 Thread Luc Michel
This commit adds the cpu-cluster type. It aims at gathering CPUs from the same cluster in a machine. For now it only has a `cluster-id` property. Signed-off-by: Luc Michel Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Edgar E.