Re: [Qemu-devel] [PATCH v7 06/12] register: Add block initialise helper

2016-06-23 Thread Alistair Francis
On Thu, Jun 23, 2016 at 11:02 AM, Peter Maydell wrote: > On 23 June 2016 at 18:29, Alistair Francis > wrote: >> On Thu, Jun 23, 2016 at 5:55 AM, Peter Maydell >> wrote: >>> It's not clear to me which of these are input arguments to the >>> function, and which are things that the function initi

Re: [Qemu-devel] [PATCH v7 06/12] register: Add block initialise helper

2016-06-23 Thread Peter Maydell
On 23 June 2016 at 18:29, Alistair Francis wrote: > On Thu, Jun 23, 2016 at 5:55 AM, Peter Maydell > wrote: >> It's not clear to me which of these are input arguments to the >> function, and which are things that the function initializes >> (I think 'ri' is purely output?) > > The function expec

Re: [Qemu-devel] [PATCH v7 06/12] register: Add block initialise helper

2016-06-23 Thread Alistair Francis
On Thu, Jun 23, 2016 at 5:55 AM, Peter Maydell wrote: > On 22 June 2016 at 21:23, Alistair Francis > wrote: >> From: Peter Crosthwaite >> >> Add a helper that will scan a static RegisterAccessInfo Array >> and populate a container MemoryRegion with registers as defined. >> >> Signed-off-by: Pet

Re: [Qemu-devel] [PATCH v7 06/12] register: Add block initialise helper

2016-06-23 Thread Peter Maydell
On 22 June 2016 at 21:23, Alistair Francis wrote: > From: Peter Crosthwaite > > Add a helper that will scan a static RegisterAccessInfo Array > and populate a container MemoryRegion with registers as defined. > > Signed-off-by: Peter Crosthwaite > Signed-off-by: Alistair Francis > --- > The rea

[Qemu-devel] [PATCH v7 06/12] register: Add block initialise helper

2016-06-22 Thread Alistair Francis
From: Peter Crosthwaite Add a helper that will scan a static RegisterAccessInfo Array and populate a container MemoryRegion with registers as defined. Signed-off-by: Peter Crosthwaite Signed-off-by: Alistair Francis --- The reason that I'm not using GArray is because the array needs to store t