[Qemu-devel] [PATCH v7 11/20] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset

2017-09-12 Thread Eric Blake
Thanks to recent cleanups, most callers were scaling a return value of sectors into bytes (the exception, in qcow2-bitmap, will be converted to byte-based iteration later). Update the interface to do the scaling internally instead. In qcow2-bitmap, the code was specifically checking for an error

Re: [Qemu-devel] [PATCH v7 11/20] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset

2017-09-14 Thread John Snow
On 09/14/2017 07:58 AM, Eric Blake wrote: > On 09/13/2017 07:15 PM, John Snow wrote: >> >> >> On 09/12/2017 04:31 PM, Eric Blake wrote: >>> Thanks to recent cleanups, most callers were scaling a return value >>> of sectors into bytes (the exception, in qcow2-bitmap, will be >>> converted to byte-

Re: [Qemu-devel] [PATCH v7 11/20] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset

2017-09-13 Thread John Snow
On 09/12/2017 04:31 PM, Eric Blake wrote: > Thanks to recent cleanups, most callers were scaling a return value > of sectors into bytes (the exception, in qcow2-bitmap, will be > converted to byte-based iteration later). Update the interface to > do the scaling internally instead. > > In qcow2-

Re: [Qemu-devel] [PATCH v7 11/20] dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset

2017-09-14 Thread Eric Blake
On 09/13/2017 07:15 PM, John Snow wrote: > > > On 09/12/2017 04:31 PM, Eric Blake wrote: >> Thanks to recent cleanups, most callers were scaling a return value >> of sectors into bytes (the exception, in qcow2-bitmap, will be >> converted to byte-based iteration later). Update the interface to >