Re: [Qemu-devel] [PATCH v7 13/23] monitor: let suspend/resume work even with QMPs

2018-02-22 Thread Peter Xu
On Wed, Feb 21, 2018 at 04:50:58PM +, Stefan Hajnoczi wrote: > On Wed, Jan 24, 2018 at 01:39:47PM +0800, Peter Xu wrote: > > diff --git a/monitor.c b/monitor.c > > index 60bcf67b3a..76137ba2a4 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -246,6 +246,21 @@ static inline bool monitor_is_

Re: [Qemu-devel] [PATCH v7 13/23] monitor: let suspend/resume work even with QMPs

2018-02-21 Thread Stefan Hajnoczi
On Wed, Jan 24, 2018 at 01:39:47PM +0800, Peter Xu wrote: > diff --git a/monitor.c b/monitor.c > index 60bcf67b3a..76137ba2a4 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -246,6 +246,21 @@ static inline bool monitor_is_qmp(const Monitor *mon) > return (mon->flags & MONITOR_USE_CONTROL); >

[Qemu-devel] [PATCH v7 13/23] monitor: let suspend/resume work even with QMPs

2018-01-23 Thread Peter Xu
This patches allows QMP monitors to be suspended/resumed. One thing to mention is that for QMPs that are using IOThreads, we need an explicit kick for the IOThread in case it is sleeping. Meanwhile, we need to take special care on non-interactive HMPs. Currently only gdbserver is using that. For