[Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() support

2013-10-11 Thread Jeff Cody
This adds support for VHDX image creation, for images of type "Fixed" and "Dynamic". "Differencing" types (i.e., VHDX images with backing files) are currently not supported. Options for image creation include: * log size: The size of the journaling log for VHDX. Minimum is 1MB,

Re: [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() support

2013-10-17 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 02:17:36PM -0400, Jeff Cody wrote: > +if (image_size > VHDX_MAX_IMAGE_SIZE) { > +fprintf(stderr, "Image size too large; max of 64TB\n"); Please use error_setg_errno(errp, EINVAL, "Image size too large; max of 64TB") instead of fprintf(). There are other instan