Re: [Qemu-devel] [PATCH v7 16/35] target/riscv: Convert RV priv insns to decodetree

2019-02-15 Thread Bastian Koppelmann
On 2/13/19 4:53 PM, Palmer Dabbelt wrote: +} + +static bool trans_sret(DisasContext *ctx, arg_sret *a) +{ +#ifndef CONFIG_USER_ONLY +tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next); + +if (riscv_has_ext(ctx->env, RVS)) { This should use has_ext() Cheers, Bastian

[Qemu-devel] [PATCH v7 16/35] target/riscv: Convert RV priv insns to decodetree

2019-02-13 Thread Palmer Dabbelt
From: Bastian Koppelmann Acked-by: Alistair Francis Reviewed-by: Richard Henderson Signed-off-by: Bastian Koppelmann Signed-off-by: Peer Adelt --- target/riscv/insn32.decode| 15 +++ .../riscv/insn_trans/trans_privileged.inc.c | 110 ++