Re: [Qemu-devel] [PATCH v7 for-2.12 21/25] block: Purify .bdrv_refresh_filename()

2018-02-02 Thread Max Reitz
On 2017-12-04 19:25, Max Reitz wrote: > On 2017-12-04 17:37, Alberto Garcia wrote: >> On Mon 20 Nov 2017 09:10:00 PM CET, Max Reitz wrote: >>> -static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) >>> +static void blkdebug_refresh_filename(BlockDriverState *bs) >>> { >>>

Re: [Qemu-devel] [PATCH v7 for-2.12 21/25] block: Purify .bdrv_refresh_filename()

2017-12-04 Thread Max Reitz
On 2017-12-04 17:37, Alberto Garcia wrote: > On Mon 20 Nov 2017 09:10:00 PM CET, Max Reitz wrote: >> -static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) >> +static void blkdebug_refresh_filename(BlockDriverState *bs) >> { >> BDRVBlkdebugState *s = bs->opaque; >> -

Re: [Qemu-devel] [PATCH v7 for-2.12 21/25] block: Purify .bdrv_refresh_filename()

2017-12-04 Thread Alberto Garcia
On Mon 20 Nov 2017 09:10:00 PM CET, Max Reitz wrote: > -static void blkdebug_refresh_filename(BlockDriverState *bs, QDict *options) > +static void blkdebug_refresh_filename(BlockDriverState *bs) > { > BDRVBlkdebugState *s = bs->opaque; > -QDict *opts; > const QDictEntry *e; > -bo

[Qemu-devel] [PATCH v7 for-2.12 21/25] block: Purify .bdrv_refresh_filename()

2017-11-20 Thread Max Reitz
Currently, BlockDriver.bdrv_refresh_filename() is supposed to both refresh the filename (BDS.exact_filename) and set BDS.full_open_options. Now that we have generic code in the central bdrv_refresh_filename() for creating BDS.full_open_options, we can drop the latter part from all BlockDriver.bdrv_