Re: [Qemu-devel] [PATCH v8 10/12] VMDK: create different subformats

2011-07-09 Thread Fam Zheng
On Fri, Jul 8, 2011 at 11:29 PM, Stefan Hajnoczi wrote: > On Tue, Jul 5, 2011 at 12:31 PM, Fam Zheng wrote: >> Add create option 'format', with enums: > > The -drive format=... option exists in QEMU today to specify the image > format of a file.  I think adding a format=... creation option may >

Re: [Qemu-devel] [PATCH v8 10/12] VMDK: create different subformats

2011-07-08 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 12:31 PM, Fam Zheng wrote: > Add create option 'format', with enums: The -drive format=... option exists in QEMU today to specify the image format of a file. I think adding a format=... creation option may lead to confusion. How about subformat=... or type=...? > Each cr

[Qemu-devel] [PATCH v8 10/12] VMDK: create different subformats

2011-07-05 Thread Fam Zheng
Add create option 'format', with enums: monolithicSparse monolithicFlat twoGbMaxExtentSparse twoGbMaxExtentFlat Each creates a subformat image file. The default is monolithiSparse. Signed-off-by: Fam Zheng --- block/vmdk.c | 561 ++