Re: [Qemu-devel] [PATCH v8 11/12] spapr: introduce a new sPAPR IRQ backend supporting XIVE and XICS

2018-12-20 Thread David Gibson
On Wed, Dec 19, 2018 at 08:15:36PM +0100, Cédric Le Goater wrote: > [ ... ] > > >>> +static qemu_irq spapr_qirq_dual(sPAPRMachineState *spapr, int irq) > >>> +{ > >>> +return spapr_irq_current(spapr)->qirq(spapr, irq); > >>> +} > >> > >> This still makes me really nervous - I'd really prefer t

Re: [Qemu-devel] [PATCH v8 11/12] spapr: introduce a new sPAPR IRQ backend supporting XIVE and XICS

2018-12-19 Thread Cédric Le Goater
[ ... ] >>> +static qemu_irq spapr_qirq_dual(sPAPRMachineState *spapr, int irq) >>> +{ >>> +return spapr_irq_current(spapr)->qirq(spapr, irq); >>> +} >> >> This still makes me really nervous - I'd really prefer to have qirqs >> independent of the backend, rather than relying on *every* irq usi

Re: [Qemu-devel] [PATCH v8 11/12] spapr: introduce a new sPAPR IRQ backend supporting XIVE and XICS

2018-12-17 Thread Cédric Le Goater
On 12/17/18 7:07 AM, David Gibson wrote: > On Tue, Dec 11, 2018 at 11:38:22PM +0100, Cédric Le Goater wrote: >> The 'dual' sPAPR IRQ backend supports both interrupt mode, XIVE >> exploitation mode and the legacy compatibility mode (XICS). both modes >> are not supported at the same time. >> >> The

Re: [Qemu-devel] [PATCH v8 11/12] spapr: introduce a new sPAPR IRQ backend supporting XIVE and XICS

2018-12-16 Thread David Gibson
On Tue, Dec 11, 2018 at 11:38:22PM +0100, Cédric Le Goater wrote: > The 'dual' sPAPR IRQ backend supports both interrupt mode, XIVE > exploitation mode and the legacy compatibility mode (XICS). both modes > are not supported at the same time. > > The machine starts with the legacy mode and a new i

[Qemu-devel] [PATCH v8 11/12] spapr: introduce a new sPAPR IRQ backend supporting XIVE and XICS

2018-12-11 Thread Cédric Le Goater
The 'dual' sPAPR IRQ backend supports both interrupt mode, XIVE exploitation mode and the legacy compatibility mode (XICS). both modes are not supported at the same time. The machine starts with the legacy mode and a new interrupt mode can then be negotiated by the CAS process. In this case, the n