Re: [Qemu-devel] [PATCH v8 11/16] qapi-event: Reduce chance of collision with event data

2016-07-13 Thread Eric Blake
On 07/07/2016 05:37 AM, Markus Armbruster wrote: > Eric Blake writes: > >> When an unboxed event has accompanying data, we are exposing all >> of its members alongside our local variables in the generated >> qapi_event_send_FOO() function. So far, we haven't hit a >>

Re: [Qemu-devel] [PATCH v8 11/16] qapi-event: Reduce chance of collision with event data

2016-07-07 Thread Markus Armbruster
Eric Blake writes: > When an unboxed event has accompanying data, we are exposing all > of its members alongside our local variables in the generated > qapi_event_send_FOO() function. So far, we haven't hit a > collision, but it may be a matter of time before someone wants >

[Qemu-devel] [PATCH v8 11/16] qapi-event: Reduce chance of collision with event data

2016-07-02 Thread Eric Blake
When an unboxed event has accompanying data, we are exposing all of its members alongside our local variables in the generated qapi_event_send_FOO() function. So far, we haven't hit a collision, but it may be a matter of time before someone wants to name a QMP data element 'err' or similar. We