Re: [Qemu-devel] [PATCH v8 2/5] Extract some reusable vGIC code

2015-08-11 Thread Pavel Fedin
Hello! > The need to add num_irq to this prototype reveals the ugliness > of it as an interface. > I don't think we gain much by making these two functions common, > and we do get a lot of churn in the existing code below. You know, i was also thinking about it. And actually there is a way to

Re: [Qemu-devel] [PATCH v8 2/5] Extract some reusable vGIC code

2015-08-10 Thread Peter Maydell
On 10 August 2015 at 13:06, Pavel Fedin wrote: > These functions are useful also for vGICv3 implementation. Make them > accessible > from within other modules. > > Actually kvm_dist_get() and kvm_dist_put() could also be made reusable, but > they would require two extra parameters (s->dev_fd and

[Qemu-devel] [PATCH v8 2/5] Extract some reusable vGIC code

2015-08-10 Thread Pavel Fedin
These functions are useful also for vGICv3 implementation. Make them accessible from within other modules. Actually kvm_dist_get() and kvm_dist_put() could also be made reusable, but they would require two extra parameters (s->dev_fd and s->num_cpu) as well as lots of typecasts of 's' to DeviceSta