[Qemu-devel] [PATCH v8 5/9] module: implement module loading function

2013-09-13 Thread Fam Zheng
Added three types of modules: typedef enum { MODULE_LOAD_BLOCK = 0, MODULE_LOAD_UI, MODULE_LOAD_NET, MODULE_LOAD_MAX, } module_load_type; and their loading function: void module_load(module_load_type). which loads all .so files in a subdir under

Re: [Qemu-devel] [PATCH v8 5/9] module: implement module loading function

2013-09-13 Thread Alex Bligh
On 13 Sep 2013, at 09:38, Fam Zheng wrote: Added three types of modules: typedef enum { MODULE_LOAD_BLOCK = 0, MODULE_LOAD_UI, MODULE_LOAD_NET, MODULE_LOAD_MAX, } module_load_type; and their loading function: What is the advantage of this enum and

Re: [Qemu-devel] [PATCH v8 5/9] module: implement module loading function

2013-09-13 Thread Paolo Bonzini
Il 13/09/2013 11:56, Alex Bligh ha scritto: On 13 Sep 2013, at 09:38, Fam Zheng wrote: Added three types of modules: typedef enum { MODULE_LOAD_BLOCK = 0, MODULE_LOAD_UI, MODULE_LOAD_NET, MODULE_LOAD_MAX, } module_load_type; and their loading

Re: [Qemu-devel] [PATCH v8 5/9] module: implement module loading function

2013-09-13 Thread Fam Zheng
On Fri, 09/13 10:56, Alex Bligh wrote: On 13 Sep 2013, at 09:38, Fam Zheng wrote: Added three types of modules: typedef enum { MODULE_LOAD_BLOCK = 0, MODULE_LOAD_UI, MODULE_LOAD_NET, MODULE_LOAD_MAX, } module_load_type; and their loading

Re: [Qemu-devel] [PATCH v8 5/9] module: implement module loading function

2013-09-13 Thread Alex Bligh
On 13 Sep 2013, at 11:02, Paolo Bonzini wrote: Seems like an overcomplication. At least block have to be separate, since qemu-img and friends do not have the symbols needed by ui, network and hardware modules. But don't we know what the available modules are at load time? So qemu-img