Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Kevin Wolf
Am 30.11.2015 um 17:19 hat Eric Blake geschrieben: > On 11/27/2015 12:35 PM, Programmingkid wrote: > > >> Unusual indentation; more typical is: > >> > >> | static kern_return_t FindEjectableOpticalMedia(io_iterator_t > >> *mediaIterator, > >> | char *mediatType) > > > > I agree. I wanted the

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Programmingkid
On Nov 30, 2015, at 11:26 AM, Kevin Wolf wrote: > Am 30.11.2015 um 17:19 hat Eric Blake geschrieben: >> On 11/27/2015 12:35 PM, Programmingkid wrote: >> Unusual indentation; more typical is: | static kern_return_t FindEjectableOpticalMedia(io_iterator_t *mediaIterator,

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Eric Blake
On 11/30/2015 09:38 AM, Programmingkid wrote: >> +/* if a working partition on the device was not found */ >> +if (partition_found == false) { >> +error_setg(errp, "Error: Failed to find a working partition on " >> +

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Eric Blake
On 11/27/2015 12:35 PM, Programmingkid wrote: >> Unusual indentation; more typical is: >> >> | static kern_return_t FindEjectableOpticalMedia(io_iterator_t >> *mediaIterator, >> | char *mediatType) > > I agree. I wanted the second long to be right justified with the 80 character > line count.

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-27 Thread Programmingkid
On Nov 25, 2015, at 11:23 PM, Eric Blake wrote: > On 11/25/2015 09:10 PM, Programmingkid wrote: >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Most mounted volumes >> appear to be off limits to QEMU. If an issue is detected, >> a message is

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-27 Thread Programmingkid
On Nov 25, 2015, at 11:29 PM, Eric Blake wrote: > On 11/25/2015 09:23 PM, Eric Blake wrote: > >>> +static kern_return_t FindEjectableOpticalMedia(io_iterator_t >>> *mediaIterator, >>> +char >>> *mediaType) >> >> Unusual

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-25 Thread Eric Blake
On 11/25/2015 09:10 PM, Programmingkid wrote: > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message is displayed showing the user how to unmount a > volume. > >

[Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-25 Thread Programmingkid
Mac OS X can be picky when it comes to allowing the user to use physical devices in QEMU. Most mounted volumes appear to be off limits to QEMU. If an issue is detected, a message is displayed showing the user how to unmount a volume. Signed-off-by: John Arbuckle ---

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-25 Thread Eric Blake
On 11/25/2015 09:23 PM, Eric Blake wrote: >> +static kern_return_t FindEjectableOpticalMedia(io_iterator_t *mediaIterator, >> +char >> *mediaType) > > Unusual indentation; more typical is: > > | static kern_return_t