[Qemu-devel] [PATCH v9 08/13] pci: Convert msi_init() to Error and fix callers to check it

2016-06-20 Thread Cao jin
msi_init() reports errors with error_report(), which is wrong when it's used in realize(). Fix by converting it to Error. Fix its callers to handle failure instead of ignoring it. For those callers who don't handle the failure, it might happen: when user want msi on, but he doesn't get what he

Re: [Qemu-devel] [PATCH v9 08/13] pci: Convert msi_init() to Error and fix callers to check it

2016-06-20 Thread Hannes Reinecke
On 06/20/2016 08:13 AM, Cao jin wrote: > msi_init() reports errors with error_report(), which is wrong > when it's used in realize(). > > Fix by converting it to Error. > > Fix its callers to handle failure instead of ignoring it. > > For those callers who don't handle the failure, it might