Hi,
> Done, thanks for the correction. Do you have a lightweight test vector
> that exercises this? The iovec stuff in my areas is all limited to
> single iovec element. Interdiff below.
hw/usb/dev-network.c (with TRAFFC_DEBUG) calls this on usb packets which
could trigger this in theory. Dep
On Tue, Feb 19, 2013 at 6:35 PM, Gerd Hoffmann wrote:
> Hi,
>
>> I ran git blame on it and its actually Gerds code. Gerd you want
>> co-authorship and the (c) of this hexdump.c?
>
> Yes.
>
> And don't break iov_hexdump() behavior please. I suggest to just
> iov_to_buf() into a temporary buffer,
Hi,
> I ran git blame on it and its actually Gerds code. Gerd you want
> co-authorship and the (c) of this hexdump.c?
Yes.
And don't break iov_hexdump() behavior please. I suggest to just
iov_to_buf() into a temporary buffer, then pass that to a single hexdump
call. When calling hexdump for
Hi Michael,
On Fri, Feb 8, 2013 at 6:42 PM, Michael Tokarev wrote:
> 08.02.2013 07:42, Peter Crosthwaite wrote:
>> Factor out the hexdumper functionality from iov for all to use. Useful for
>> creating verbose debug printfery that dumps packet data.
>
> Two comments below.
>
>> diff --git a/inclu
08.02.2013 07:42, Peter Crosthwaite wrote:
> Factor out the hexdumper functionality from iov for all to use. Useful for
> creating verbose debug printfery that dumps packet data.
Two comments below.
> diff --git a/include/qemu/hexdump.h b/include/qemu/hexdump.h
> new file mode 100644
> index
Factor out the hexdumper functionality from iov for all to use. Useful for
creating verbose debug printfery that dumps packet data.
Signed-off-by: Peter Crosthwaite
---
include/qemu/hexdump.h |3 +++
util/Makefile.objs |1 +
util/hexdump.c | 45
