Re: [Qemu-devel] [PATCH v9 10/37] qapi: Make all visitors supply uint64 callbacks

2016-01-21 Thread Markus Armbruster
Eric Blake writes: > On 01/20/2016 10:29 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Our qapi visitor contract supports multiple integer visitors, >>> but left the type_uint64 visitor as optional (falling back on >>> type_int64); it also

Re: [Qemu-devel] [PATCH v9 10/37] qapi: Make all visitors supply uint64 callbacks

2016-01-21 Thread Eric Blake
On 01/21/2016 01:56 AM, Markus Armbruster wrote: >>> Before: nobody implements type_uint64(), and the core falls back to >>> type_int64(), casting negative values to large positive ones. With an >>> implementation of type_int64() that parses large positive values as >>> negative, the two casts

Re: [Qemu-devel] [PATCH v9 10/37] qapi: Make all visitors supply uint64 callbacks

2016-01-20 Thread Markus Armbruster
Eric Blake writes: > Our qapi visitor contract supports multiple integer visitors, > but left the type_uint64 visitor as optional (falling back on > type_int64); it also marks the type_size visitor as optional > (falling back on type_uint64 or even type_int64). > > Note that

Re: [Qemu-devel] [PATCH v9 10/37] qapi: Make all visitors supply uint64 callbacks

2016-01-20 Thread Eric Blake
On 01/20/2016 10:29 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Our qapi visitor contract supports multiple integer visitors, >> but left the type_uint64 visitor as optional (falling back on >> type_int64); it also marks the type_size visitor as optional >> (falling

[Qemu-devel] [PATCH v9 10/37] qapi: Make all visitors supply uint64 callbacks

2016-01-19 Thread Eric Blake
Our qapi visitor contract supports multiple integer visitors, but left the type_uint64 visitor as optional (falling back on type_int64); it also marks the type_size visitor as optional (falling back on type_uint64 or even type_int64). Note that the default of falling back on type_int for unsigned