Re: [Qemu-devel] [PATCH v9 15/37] qom: Swap 'name' next to visitor in ObjectPropertyAccessor

2016-01-21 Thread Markus Armbruster
Eric Blake writes: > On 01/20/2016 11:49 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Similar to the previous patch, it's nice to have all functions >>> in the tree that involve a visitor and a name for conversion to >>> or from QAPI to

Re: [Qemu-devel] [PATCH v9 15/37] qom: Swap 'name' next to visitor in ObjectPropertyAccessor

2016-01-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 21.01.2016 um 10:18 hat Markus Armbruster geschrieben: >> Eric Blake writes: >> > On 01/20/2016 11:49 AM, Markus Armbruster wrote: >> >> Eric Blake writes: >> >> >> >> However, the actual match is looser! For

Re: [Qemu-devel] [PATCH v9 15/37] qom: Swap 'name' next to visitor in ObjectPropertyAccessor

2016-01-21 Thread Kevin Wolf
Am 21.01.2016 um 10:18 hat Markus Armbruster geschrieben: > Eric Blake writes: > > On 01/20/2016 11:49 AM, Markus Armbruster wrote: > >> Eric Blake writes: > >> > >> However, the actual match is looser! For instance, it also matches > >> > >> void

Re: [Qemu-devel] [PATCH v9 15/37] qom: Swap 'name' next to visitor in ObjectPropertyAccessor

2016-01-20 Thread Markus Armbruster
Eric Blake writes: > Similar to the previous patch, it's nice to have all functions > in the tree that involve a visitor and a name for conversion to > or from QAPI to consistently stick the 'name' parameter next > to the Visitor parameter. > > Done by manually changing

Re: [Qemu-devel] [PATCH v9 15/37] qom: Swap 'name' next to visitor in ObjectPropertyAccessor

2016-01-20 Thread Eric Blake
On 01/20/2016 11:49 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Similar to the previous patch, it's nice to have all functions >> in the tree that involve a visitor and a name for conversion to >> or from QAPI to consistently stick the 'name' parameter next >> to

[Qemu-devel] [PATCH v9 15/37] qom: Swap 'name' next to visitor in ObjectPropertyAccessor

2016-01-19 Thread Eric Blake
Similar to the previous patch, it's nice to have all functions in the tree that involve a visitor and a name for conversion to or from QAPI to consistently stick the 'name' parameter next to the Visitor parameter. Done by manually changing include/qom/object.h and qom/object.c, then running this