Re: [Qemu-devel] [PATCH v9 16/37] qapi: Swap 'name' in visit_* callbacks to match public API

2016-01-21 Thread Markus Armbruster
Eric Blake writes: > On 01/20/2016 11:55 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> As explained in the previous patches, matching argument order of >>> 'name, ' to JSON's "name":value makes sense. However, >>> while the last two patches

Re: [Qemu-devel] [PATCH v9 16/37] qapi: Swap 'name' in visit_* callbacks to match public API

2016-01-20 Thread Markus Armbruster
Eric Blake writes: > As explained in the previous patches, matching argument order of > 'name, ' to JSON's "name":value makes sense. However, > while the last two patches were easy with Coccinelle, I ended up > doing this one all by hand. Now all the visitor callbacks match

Re: [Qemu-devel] [PATCH v9 16/37] qapi: Swap 'name' in visit_* callbacks to match public API

2016-01-20 Thread Eric Blake
On 01/20/2016 11:55 AM, Markus Armbruster wrote: > Eric Blake writes: > >> As explained in the previous patches, matching argument order of >> 'name, ' to JSON's "name":value makes sense. However, >> while the last two patches were easy with Coccinelle, I ended up >> doing

[Qemu-devel] [PATCH v9 16/37] qapi: Swap 'name' in visit_* callbacks to match public API

2016-01-19 Thread Eric Blake
As explained in the previous patches, matching argument order of 'name, ' to JSON's "name":value makes sense. However, while the last two patches were easy with Coccinelle, I ended up doing this one all by hand. Now all the visitor callbacks match the main interface. Signed-off-by: Eric Blake