Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-02-15 Thread Changlong Xie
On 02/09/2016 01:06 AM, Alberto Garcia wrote: On Fri 22 Jan 2016 09:02:10 PM CET, "Dr. David Alan Gilbert" wrote: In general, what do you do to make sure that the data in a new Quorum child is consistent with that of the rest of the array? Quorum can have more than one

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-02-08 Thread Alberto Garcia
On Fri 22 Jan 2016 09:02:10 PM CET, "Dr. David Alan Gilbert" wrote: >> In general, what do you do to make sure that the data in a new >> Quorum child is consistent with that of the rest of the array? >> >>> >> >>> Quorum can have more than one child when it

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-01-24 Thread Wen Congyang
On 01/23/2016 04:02 AM, Dr. David Alan Gilbert wrote: > * Alberto Garcia (be...@igalia.com) wrote: >> On Thu 21 Jan 2016 05:58:42 PM CET, Eric Blake wrote: >> In general, what do you do to make sure that the data in a new Quorum >> child is consistent with that of the

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-01-22 Thread Dr. David Alan Gilbert
* Alberto Garcia (be...@igalia.com) wrote: > On Thu 21 Jan 2016 05:58:42 PM CET, Eric Blake wrote: > In general, what do you do to make sure that the data in a new Quorum > child is consistent with that of the rest of the array? > >>> > >>> Quorum can have more than

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-01-22 Thread Alberto Garcia
On Thu 21 Jan 2016 05:58:42 PM CET, Eric Blake wrote: In general, what do you do to make sure that the data in a new Quorum child is consistent with that of the rest of the array? >>> >>> Quorum can have more than one child when it starts. But we don't do >>> the

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-01-21 Thread Alberto Garcia
On Thu 21 Jan 2016 02:54:10 AM CET, Wen Congyang wrote: >>> @@ -875,9 +878,9 @@ static int quorum_open(BlockDriverState *bs, QDict >>> *options, int flags, >>> ret = -EINVAL; >>> goto exit; >>> } >>> -if (s->num_children < 2) { >>> +if

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-01-21 Thread Eric Blake
On 01/21/2016 06:05 AM, Alberto Garcia wrote: > On Thu 21 Jan 2016 02:54:10 AM CET, Wen Congyang wrote: > @@ -875,9 +878,9 @@ static int quorum_open(BlockDriverState *bs, QDict *options, int flags, ret = -EINVAL; goto exit; }

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-01-20 Thread Wen Congyang
On 01/20/2016 11:43 PM, Alberto Garcia wrote: > On Fri 25 Dec 2015 10:22:55 AM CET, Changlong Xie wrote: >> @@ -875,9 +878,9 @@ static int quorum_open(BlockDriverState *bs, QDict >> *options, int flags, >> ret = -EINVAL; >> goto exit; >> } >> -if (s->num_children < 2) {

Re: [Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-01-20 Thread Alberto Garcia
On Fri 25 Dec 2015 10:22:55 AM CET, Changlong Xie wrote: > @@ -875,9 +878,9 @@ static int quorum_open(BlockDriverState *bs, QDict > *options, int flags, > ret = -EINVAL; > goto exit; > } > -if (s->num_children < 2) { > +if (s->num_children < 1) { >

[Qemu-devel] [PATCH v9 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-12-25 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block.c | 8