Re: [Qemu-devel] [PATCH v9 20/37] qmp: Don't abuse stack to track qmp-output root

On 01/21/2016 06:58 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The previous commit documented an inconsistency in how we are >> using the stack of qmp-output-visitor. Normally, pushing a >> single top-level object puts the object on the stack twice: >> once as the

Re: [Qemu-devel] [PATCH v9 20/37] qmp: Don't abuse stack to track qmp-output root

Eric Blake writes: > The previous commit documented an inconsistency in how we are > using the stack of qmp-output-visitor. Normally, pushing a > single top-level object puts the object on the stack twice: > once as the root, and once as the current container being > appended

[Qemu-devel] [PATCH v9 20/37] qmp: Don't abuse stack to track qmp-output root

The previous commit documented an inconsistency in how we are using the stack of qmp-output-visitor. Normally, pushing a single top-level object puts the object on the stack twice: once as the root, and once as the current container being appended to; but popping that struct only pops once.