Re: [Qemu-devel] [PATCHv2] [RFC 1/7] aio / timers: Remove alarm timers

2013-07-25 Thread Alex Bligh
Stefan, This should be one of the last patches so qemu.git remains bisectable. Only remove the alarm timer once the event loops are already using the timeout argument. OK @@ -245,11 +82,7 @@ static QEMUClock *qemu_new_clock(int type) void qemu_clock_enable(QEMUClock *clock, bool enabled)

Re: [Qemu-devel] [PATCHv2] [RFC 1/7] aio / timers: Remove alarm timers

2013-07-25 Thread Paolo Bonzini
Il 25/07/2013 11:37, Alex Bligh ha scritto: > Stefan, > >> This should be one of the last patches so qemu.git remains bisectable. >> Only remove the alarm timer once the event loops are already using the >> timeout argument. > > OK > >>> @@ -245,11 +82,7 @@ static QEMUClock *qemu_new_clock(int t

Re: [Qemu-devel] [PATCHv2] [RFC 1/7] aio / timers: Remove alarm timers

2013-07-25 Thread Alex Bligh
--On 25 July 2013 11:11:22 +0200 Paolo Bonzini wrote: If this function is supposed to work when called from another thread (e.g. vcpu thread), then you need to call qemu_notify_event(). For AioContext clocks that should be aio_notify() with the relevant AioContext, but we don't need that yet

Re: [Qemu-devel] [PATCHv2] [RFC 1/7] aio / timers: Remove alarm timers

2013-07-25 Thread Paolo Bonzini
Il 25/07/2013 11:10, Stefan Hajnoczi ha scritto: > On Sat, Jul 20, 2013 at 07:06:37PM +0100, Alex Bligh wrote: >> Remove alarm timers from qemu-timers.c in anticipation of using >> timeouts for g_poll / p_poll instead. >> >> Signed-off-by: Alex Bligh >> --- >> include/qemu/timer.h |2 - >> ma

Re: [Qemu-devel] [PATCHv2] [RFC 1/7] aio / timers: Remove alarm timers

2013-07-25 Thread Stefan Hajnoczi
On Sat, Jul 20, 2013 at 07:06:37PM +0100, Alex Bligh wrote: > Remove alarm timers from qemu-timers.c in anticipation of using > timeouts for g_poll / p_poll instead. > > Signed-off-by: Alex Bligh > --- > include/qemu/timer.h |2 - > main-loop.c |4 - > qemu-timer.c | 50

[Qemu-devel] [PATCHv2] [RFC 1/7] aio / timers: Remove alarm timers

2013-07-20 Thread Alex Bligh
Remove alarm timers from qemu-timers.c in anticipation of using timeouts for g_poll / p_poll instead. Signed-off-by: Alex Bligh --- include/qemu/timer.h |2 - main-loop.c |4 - qemu-timer.c | 501 +- vl.c |