On (Mon) 02 Jan 2012 [17:55:06], Alexander Graf wrote:
>
> On 02.01.2012, at 16:41, Christian Borntraeger wrote:
>
> > On 02/01/12 16:34, Alexander Graf wrote:
> if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
> virtio_serial_throttle_port(port, true);
> >>
On 02.01.2012, at 16:41, Christian Borntraeger wrote:
> On 02/01/12 16:34, Alexander Graf wrote:
if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
virtio_serial_throttle_port(port, true);
>>>
>>> Ah; I see what's happening. pty_chr_write() returns 0 if a cl
On 02/01/12 16:34, Alexander Graf wrote:
>>>if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
>>>virtio_serial_throttle_port(port, true);
>>
>> Ah; I see what's happening. pty_chr_write() returns 0 if a client
>> isn't yet connected.
>>
>> This is different from the
On 29.12.2011, at 16:14, Amit Shah wrote:
> On (Thu) 29 Dec 2011 [15:32:14], Christian Borntraeger wrote:
>>> port->throttled never becomes true for qemu.
>>
>> Huh? What did I miss below?
>>
>>if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
>>virtio_serial_t
On 29/12/11 15:56, Amit Shah wrote:
> On (Thu) 29 Dec 2011 [15:32:14], Christian Borntraeger wrote:
>>> port->throttled never becomes true for qemu.
>>
>> Huh? What did I miss below?
>>
>> if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
>> virtio_serial_throttle_
On (Thu) 29 Dec 2011 [15:32:14], Christian Borntraeger wrote:
> > port->throttled never becomes true for qemu.
>
> Huh? What did I miss below?
>
> if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
> virtio_serial_throttle_port(port, true);
Ah; I see what's happe
On (Thu) 29 Dec 2011 [15:32:14], Christian Borntraeger wrote:
> > port->throttled never becomes true for qemu.
>
> Huh? What did I miss below?
>
> if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
> virtio_serial_throttle_port(port, true);
'ret' here is the retu
> port->throttled never becomes true for qemu.
Huh? What did I miss below?
if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
virtio_serial_throttle_port(port, true);
|
On (Thu) 29 Dec 2011 [15:16:55], Christian Borntraeger wrote:
> >> +++ b/hw/virtio-serial-bus.c
> >> @@ -163,7 +163,19 @@ static void do_flush_queued_data(VirtIOS
> >> abort();
> >> }
> >> if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
> >> -
>> I'm surprised: did you test this with upstream qemu? That codebase
>> doesn't yet throttle writes, and this code path won't execute. Does
>> it really not reproduce with this patch?
>
> I think
> static void handle_output(VirtIODevice *vdev, VirtQueue *vq)
> []
> if (!port->throttled
>> +++ b/hw/virtio-serial-bus.c
>> @@ -163,7 +163,19 @@ static void do_flush_queued_data(VirtIOS
>> abort();
>> }
>> if (ret == -EAGAIN || (ret >= 0 && ret < buf_size)) {
>> -virtio_serial_throttle_port(port, true);
>
> I'm surprised: did
On (Thu) 29 Dec 2011 [13:47:43], Christian Borntraeger wrote:
> From: Christian Borntraeger
>
> when I tried qemu with -virtio-console pty the guest hangs and attaching on
> /dev/pts/ does
> not return anything if the attachement is too late.
> Turns out that the console is already throttled
Am 29.12.2011 14:27, schrieb Amit Shah:
> On (Thu) 29 Dec 2011 [13:47:43], Christian Borntraeger wrote:
>> From: Christian Borntraeger
>>
>> when I tried qemu with -virtio-console pty the guest hangs and attaching on
>> /dev/pts/ does
>> not return anything if the attachement is too late.
"
On (Thu) 29 Dec 2011 [13:47:43], Christian Borntraeger wrote:
> From: Christian Borntraeger
>
> when I tried qemu with -virtio-console pty the guest hangs and attaching on
> /dev/pts/ does
> not return anything if the attachement is too late.
> Turns out that the console is already throttled
From: Christian Borntraeger
when I tried qemu with -virtio-console pty the guest hangs and attaching on
/dev/pts/ does
not return anything if the attachement is too late.
Turns out that the console is already throttled and the guest is heavily
spinning but get_buf
never returns the buffer.
15 matches
Mail list logo
