Re: [Qemu-devel] [PATCHv2] curses ui: always initialize all curses_line fields

2019-03-18 Thread Gerd Hoffmann
On Fri, Mar 15, 2019 at 02:09:32PM +0100, Samuel Thibault wrote: > cchar_t can contain not only attr and chars fields, but also ext_color. > Initialize the whole structure to zero instead of enumerating fields. > > Spotted by Coverity: CID 1399711 > > Signed-off-by: Samuel Thibault Added to UI

Re: [Qemu-devel] [PATCHv2] curses ui: always initialize all curses_line fields

2019-03-15 Thread Philippe Mathieu-Daudé
On 3/15/19 2:09 PM, Samuel Thibault wrote: > cchar_t can contain not only attr and chars fields, but also ext_color. > Initialize the whole structure to zero instead of enumerating fields. > > Spotted by Coverity: CID 1399711 > > Signed-off-by: Samuel Thibault > --- > ui/curses.c | 6 +++--- >

[Qemu-devel] [PATCHv2] curses ui: always initialize all curses_line fields

2019-03-15 Thread Samuel Thibault
cchar_t can contain not only attr and chars fields, but also ext_color. Initialize the whole structure to zero instead of enumerating fields. Spotted by Coverity: CID 1399711 Signed-off-by: Samuel Thibault --- ui/curses.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCHv2] curses ui: always initialize all curses_line fields

2019-03-15 Thread Peter Maydell
On Fri, 15 Mar 2019 at 13:09, Samuel Thibault wrote: > > cchar_t can contain not only attr and chars fields, but also ext_color. > Initialize the whole structure to zero instead of enumerating fields. > > Spotted by Coverity: CID 1399711 > > Signed-off-by: Samuel Thibault > --- > ui/curses.c |