Re: [Qemu-devel] [PATCHv2] slirp: Fix spurious error report when sending directly

2018-05-31 Thread Philippe Mathieu-Daudé
On 05/31/2018 05:31 PM, Samuel Thibault wrote: > Move check to where it actually is useful, and reduce scope of 'len' > variable along the way. > > Signed-off-by: Samuel Thibault Thanks! Reviewed-by: Philippe Mathieu-Daudé > --- > > Difference from v1: > - move check instead of initializing

Re: [Qemu-devel] [PATCHv2] slirp: Fix spurious error report when sending directly

2018-05-31 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180531203110.17203-1-samuel.thiba...@ens-lyon.org Subject: [Qemu-devel] [PATCHv2] slirp: Fix spurious error report when sending directly === TEST SCRIPT BEGIN === #!/bin

[Qemu-devel] [PATCHv2] slirp: Fix spurious error report when sending directly

2018-05-31 Thread Samuel Thibault
Move check to where it actually is useful, and reduce scope of 'len' variable along the way. Signed-off-by: Samuel Thibault --- Difference from v1: - move check instead of initializing len. slirp/socket.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/slirp/