Re: [Qemu-devel] [PATCHv2 3/8] spapr: Simplify unplug path

2017-07-12 Thread David Gibson
On Wed, Jul 12, 2017 at 12:31:48PM +0200, Greg Kurz wrote: > On Wed, 12 Jul 2017 12:04:51 +0200 > Greg Kurz wrote: > > > On Wed, 12 Jul 2017 15:53:12 +1000 > > David Gibson wrote: > > > > > spapr_lmb_release() and spapr_core_release() call

Re: [Qemu-devel] [PATCHv2 3/8] spapr: Simplify unplug path

2017-07-12 Thread Greg Kurz
On Wed, 12 Jul 2017 12:04:51 +0200 Greg Kurz wrote: > On Wed, 12 Jul 2017 15:53:12 +1000 > David Gibson wrote: > > > spapr_lmb_release() and spapr_core_release() call hotplug_handler_unplug() > > which after a bunch of indirection calls

Re: [Qemu-devel] [PATCHv2 3/8] spapr: Simplify unplug path

2017-07-12 Thread Greg Kurz
On Wed, 12 Jul 2017 15:53:12 +1000 David Gibson wrote: > spapr_lmb_release() and spapr_core_release() call hotplug_handler_unplug() > which after a bunch of indirection calls spapr_memory_unplug() or > spapr_core_unplug(). But we already know which is the

[Qemu-devel] [PATCHv2 3/8] spapr: Simplify unplug path

2017-07-11 Thread David Gibson
spapr_lmb_release() and spapr_core_release() call hotplug_handler_unplug() which after a bunch of indirection calls spapr_memory_unplug() or spapr_core_unplug(). But we already know which is the appropriate thing to call here, so we can just fold it directly into the release function. Once