Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

2017-12-06 Thread Mark Cave-Ayland
On 05/12/17 15:13, Stefan Weil wrote: Am 05.12.2017 um 09:17 schrieb Mark Cave-Ayland: Signed-off-by: Mark Cave-Ayland --- hw/net/eepro100.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index 1c0def555b..4fe94b

Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

2017-12-06 Thread Mark Cave-Ayland
On 05/12/17 14:28, Eric Blake wrote: On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland --- hw/net/eepro100.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) -if (carry) { -crc = ((crc ^ POLYNOMIAL) | car

Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

2017-12-05 Thread Philippe Mathieu-Daudé
On 12/05/2017 05:17 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > --- > hw/net/eepro100.c | 19 +-- > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c > index 1c0def555b

Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

2017-12-05 Thread Stefan Weil
Am 05.12.2017 um 16:13 schrieb Stefan Weil: > Am 05.12.2017 um 09:17 schrieb Mark Cave-Ayland: >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/net/eepro100.c | 19 +-- >> 1 file changed, 1 insertion(+), 18 deletions(-) >> >> diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c >> in

Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

2017-12-05 Thread Stefan Weil
Am 05.12.2017 um 09:17 schrieb Mark Cave-Ayland: > Signed-off-by: Mark Cave-Ayland > --- > hw/net/eepro100.c | 19 +-- > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c > index 1c0def555b..4fe94b7471 100644 > --- a/hw/net/eepr

Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

2017-12-05 Thread Eric Blake
On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/net/eepro100.c | 19 +-- > 1 file changed, 1 insertion(+), 18 deletions(-) > > -if (carry) { > -crc = ((crc ^ POLYNOMIAL) | carry); How does this compile aft

[Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32()

2017-12-05 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/net/eepro100.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/hw/net/eepro100.c b/hw/net/eepro100.c index 1c0def555b..4fe94b7471 100644 --- a/hw/net/eepro100.c +++ b/hw/net/eepro100.c @@ -327,26 +327,9 @@ static const