Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-06 Thread Markus Armbruster
Gleb Natapov writes: > On Sat, Nov 06, 2010 at 10:25:31AM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Fri, Nov 05, 2010 at 05:31:38PM +0100, Markus Armbruster wrote: >> >> Gleb Natapov writes: >> >> >> >> > On Fri, Nov 05, 2010 at 03:04:05PM +0100, Markus Armbruster wro

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-06 Thread Gleb Natapov
On Sat, Nov 06, 2010 at 10:25:31AM +0100, Markus Armbruster wrote: > Gleb Natapov writes: > > > On Fri, Nov 05, 2010 at 05:31:38PM +0100, Markus Armbruster wrote: > >> Gleb Natapov writes: > >> > >> > On Fri, Nov 05, 2010 at 03:04:05PM +0100, Markus Armbruster wrote: > >> [...] > >> >> >> >> Th

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-06 Thread Markus Armbruster
Gleb Natapov writes: > On Fri, Nov 05, 2010 at 05:31:38PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Fri, Nov 05, 2010 at 03:04:05PM +0100, Markus Armbruster wrote: >> [...] >> >> >> >> There has been quite some discussion on "canonical path" on the >> >> >> >> list, >>

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-05 Thread Gleb Natapov
On Fri, Nov 05, 2010 at 05:31:38PM +0100, Markus Armbruster wrote: > Gleb Natapov writes: > > > On Fri, Nov 05, 2010 at 03:04:05PM +0100, Markus Armbruster wrote: > [...] > >> >> >> There has been quite some discussion on "canonical path" on the list, > >> >> >> but no consensus. Ironically, one

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-05 Thread Markus Armbruster
Gleb Natapov writes: > On Fri, Nov 05, 2010 at 03:04:05PM +0100, Markus Armbruster wrote: [...] >> >> >> There has been quite some discussion on "canonical path" on the list, >> >> >> but no consensus. Ironically, one of the places where we got stuck was >> >> >> ISA. You cut right through that

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-05 Thread Gleb Natapov
On Fri, Nov 05, 2010 at 03:04:05PM +0100, Markus Armbruster wrote: [skip] > >> Passing bus numbers explicitly isn't hard either. Programmer is free to > >> pass nonsensical numbers. For the most common case of one bus, the bus > >> number parameter is just noise. > > If programmer makes an error

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-05 Thread Markus Armbruster
Gleb Natapov writes: > On Thu, Nov 04, 2010 at 03:22:50PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Thu, Nov 04, 2010 at 09:46:57AM +0100, Markus Armbruster wrote: >> >> > But why order of device creation is important? It shouldn't be if we >> >> > want to move HW descr

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-04 Thread Gleb Natapov
On Thu, Nov 04, 2010 at 03:22:50PM +0100, Markus Armbruster wrote: > Gleb Natapov writes: > > > On Thu, Nov 04, 2010 at 09:46:57AM +0100, Markus Armbruster wrote: > >> > But why order of device creation is important? It shouldn't be if we > >> > want to move HW description into config file. We ev

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-04 Thread Markus Armbruster
Gleb Natapov writes: > On Thu, Nov 04, 2010 at 09:46:57AM +0100, Markus Armbruster wrote: >> > But why order of device creation is important? It shouldn't be if we >> > want to move HW description into config file. We even may allow creating >> > piix3-ide with only second IDE bus, but not first.

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-04 Thread Gleb Natapov
On Thu, Nov 04, 2010 at 09:46:57AM +0100, Markus Armbruster wrote: > > But why order of device creation is important? It shouldn't be if we > > want to move HW description into config file. We even may allow creating > > piix3-ide with only second IDE bus, but not first. > > That's not how buses w

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-04 Thread Markus Armbruster
Gleb Natapov writes: > On Wed, Nov 03, 2010 at 06:22:11PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Wed, Nov 03, 2010 at 04:18:18PM +0100, Markus Armbruster wrote: >> >> Gleb Natapov writes: >> >> >> >> > On Wed, Nov 03, 2010 at 02:39:52PM +0100, Markus Armbruster wro

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-04 Thread Gleb Natapov
On Wed, Nov 03, 2010 at 06:22:11PM +0100, Markus Armbruster wrote: > Gleb Natapov writes: > > > On Wed, Nov 03, 2010 at 04:18:18PM +0100, Markus Armbruster wrote: > >> Gleb Natapov writes: > >> > >> > On Wed, Nov 03, 2010 at 02:39:52PM +0100, Markus Armbruster wrote: > >> >> Here's a generic an

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-03 Thread Markus Armbruster
Gleb Natapov writes: > On Wed, Nov 03, 2010 at 04:18:18PM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Wed, Nov 03, 2010 at 02:39:52PM +0100, Markus Armbruster wrote: >> >> Here's a generic answer to the question "which of the device's buses is >> >> this?" >> >> >> >> in

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-03 Thread Gleb Natapov
On Wed, Nov 03, 2010 at 04:18:18PM +0100, Markus Armbruster wrote: > Gleb Natapov writes: > > > On Wed, Nov 03, 2010 at 02:39:52PM +0100, Markus Armbruster wrote: > >> Here's a generic answer to the question "which of the device's buses is > >> this?" > >> > >> int qbus_index(BusState *bus) > >>

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-03 Thread Markus Armbruster
Gleb Natapov writes: > On Wed, Nov 03, 2010 at 02:39:52PM +0100, Markus Armbruster wrote: >> Here's a generic answer to the question "which of the device's buses is >> this?" >> >> int qbus_index(BusState *bus) >> { >> BusState *b; >> int i, index; >> >> index = -1; >> i = 0; >>

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-03 Thread Gleb Natapov
On Wed, Nov 03, 2010 at 02:39:52PM +0100, Markus Armbruster wrote: > Here's a generic answer to the question "which of the device's buses is > this?" > > int qbus_index(BusState *bus) > { > BusState *b; > int i, index; > > index = -1; > i = 0; > QLIST_FOREACH(b, &bus->parent->

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-03 Thread Markus Armbruster
Here's a generic answer to the question "which of the device's buses is this?" int qbus_index(BusState *bus) { BusState *b; int i, index; index = -1; i = 0; QLIST_FOREACH(b, &bus->parent->child_bus, sibling) { if (b == bus) { index = i; } i+

[Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-10-31 Thread Gleb Natapov
Signed-off-by: Gleb Natapov --- hw/ide/cmd646.c |4 ++-- hw/ide/internal.h |3 ++- hw/ide/isa.c |2 +- hw/ide/piix.c |4 ++-- hw/ide/qdev.c |3 ++- hw/ide/via.c |4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/ide/cmd646.c b/