Re: [Qemu-devel] [PATCHv2 4/8] spapr: Refactor spapr_drc_detach()

2017-07-12 Thread David Gibson
On Wed, Jul 12, 2017 at 01:47:15PM +0200, Greg Kurz wrote: > On Wed, 12 Jul 2017 15:53:13 +1000 > David Gibson wrote: > > > This function has two unused parameters - remove them. > > > > It also sets awaiting_release on all paths, except one. On that path > >

Re: [Qemu-devel] [PATCHv2 4/8] spapr: Refactor spapr_drc_detach()

2017-07-12 Thread Greg Kurz
On Wed, 12 Jul 2017 15:53:13 +1000 David Gibson wrote: > This function has two unused parameters - remove them. > > It also sets awaiting_release on all paths, except one. On that path > setting it is harmless, since it will be immediately cleared by >

[Qemu-devel] [PATCHv2 4/8] spapr: Refactor spapr_drc_detach()

2017-07-11 Thread David Gibson
This function has two unused parameters - remove them. It also sets awaiting_release on all paths, except one. On that path setting it is harmless, since it will be immediately cleared by spapr_drc_release(). So factor it out of the if statements. Signed-off-by: David Gibson