Re: [Qemu-devel] [PATCHv2 5/6] target-arm: add dump-guest-memory support

2013-04-04 Thread Peter Maydell
On 4 April 2013 10:47, Paolo Bonzini wrote: > Il 24/03/2013 21:39, Peter Maydell ha scritto: >>> > (come to think of it, I guess this ARM code will need to use ELFCLASS64 >>> > when we have physical memory > 4GiB (LPAE)) >> It would be good to check whether that is correct -- mostly core >> files

Re: [Qemu-devel] [PATCHv2 5/6] target-arm: add dump-guest-memory support

2013-04-04 Thread Paolo Bonzini
Il 24/03/2013 21:39, Peter Maydell ha scritto: >> > >> > I guess the API was made with x86 in mind. I will see if the >> > requirement can be removed with some ifdefs in the dump.c file. >> > >> > (come to think of it, I guess this ARM code will need to use ELFCLASS64 >> > when we have physical m

Re: [Qemu-devel] [PATCHv2 5/6] target-arm: add dump-guest-memory support

2013-03-24 Thread Peter Maydell
On 24 March 2013 19:26, Rabin Vincent wrote: > 2013/3/24 Peter Maydell : >> On 24 March 2013 17:27, Rabin Vincent wrote: So I guess I should prefix this email by saying that quite a bit of it is really comments on the existing dump code rather than the ARM related support you're adding here. I a

Re: [Qemu-devel] [PATCHv2 5/6] target-arm: add dump-guest-memory support

2013-03-24 Thread Rabin Vincent
2013/3/24 Peter Maydell : > On 24 March 2013 17:27, Rabin Vincent wrote: >> --- /dev/null >> +++ b/target-arm/arch_dump.c >> @@ -0,0 +1,61 @@ >> +#include "cpu.h" >> +#include "sysemu/dump.h" >> +#include "elf.h" >> + >> +typedef struct { >> +char pad1[24]; >> +uint32_t pid; >> +char p

Re: [Qemu-devel] [PATCHv2 5/6] target-arm: add dump-guest-memory support

2013-03-24 Thread Peter Maydell
On 24 March 2013 17:27, Rabin Vincent wrote: > Enable support for the dump-guest-memory monitor command for ARM. Hi. I'm afraid I'm not really familiar with the dump-guest-memory command/implementation so I have some possibly dumb comments below: > --- /dev/null > +++ b/target-arm/arch_dump.c >

[Qemu-devel] [PATCHv2 5/6] target-arm: add dump-guest-memory support

2013-03-24 Thread Rabin Vincent
Enable support for the dump-guest-memory monitor command for ARM. Cc: Peter Maydell Signed-off-by: Rabin Vincent --- configure|2 +- target-arm/Makefile.objs |2 +- target-arm/arch_dump.c | 61 ++ 3 files changed, 63 insert