Re: [Qemu-devel] [PATCHv3] Add KVM paravirt cpuid leaf

2010-01-13 Thread Anthony Liguori
On 01/13/2010 07:25 AM, Gleb Natapov wrote: Initialize KVM paravirt cpuid leaf and allow user to control guest visible PV features through -cpu flag. Signed-off-by: Gleb Natapov Applied. Thanks. Regards, Anthony Liguori --- v1->v2 fix indentation remove unneeded ifdefs v2->v3

Re: [Qemu-devel] [PATCHv3] Add KVM paravirt cpuid leaf

2010-01-13 Thread Anthony Liguori
On 01/13/2010 10:23 AM, Gleb Natapov wrote: Or do you mean making so that PV leaf will be available via cpu_x86_cpuid()? This make sense, but lets do it after merging this code path with qemu-kvm and the proposed patch brings qemu and qemu-kvm close together. Yes, that's what I meant, and y

Re: [Qemu-devel] [PATCHv3] Add KVM paravirt cpuid leaf

2010-01-13 Thread Gleb Natapov
On Wed, Jan 13, 2010 at 06:14:54PM +0200, Gleb Natapov wrote: > On Wed, Jan 13, 2010 at 10:05:33AM -0600, Anthony Liguori wrote: > > >+#ifdef CONFIG_KVM_PARA > > >+/* Paravirtualization CPUIDs */ > > >+memcpy(signature, "KVMKVMKVM\0\0\0", 12); > > >+c =&cpuid_data.entries[cpuid_i++]; >

Re: [Qemu-devel] [PATCHv3] Add KVM paravirt cpuid leaf

2010-01-13 Thread Gleb Natapov
On Wed, Jan 13, 2010 at 10:05:33AM -0600, Anthony Liguori wrote: > >+#ifdef CONFIG_KVM_PARA > >+/* Paravirtualization CPUIDs */ > >+memcpy(signature, "KVMKVMKVM\0\0\0", 12); > >+c =&cpuid_data.entries[cpuid_i++]; > >+memset(c, 0, sizeof(*c)); > >+c->function = KVM_CPUID_SIGNATUR

Re: [Qemu-devel] [PATCHv3] Add KVM paravirt cpuid leaf

2010-01-13 Thread Anthony Liguori
On 01/13/2010 07:25 AM, Gleb Natapov wrote: Initialize KVM paravirt cpuid leaf and allow user to control guest visible PV features through -cpu flag. Signed-off-by: Gleb Natapov --- v1->v2 fix indentation remove unneeded ifdefs v2->v3 added needed ifdefs (CONFIG_KVM_PARA) diff --gi

[Qemu-devel] [PATCHv3] Add KVM paravirt cpuid leaf

2010-01-13 Thread Gleb Natapov
Initialize KVM paravirt cpuid leaf and allow user to control guest visible PV features through -cpu flag. Signed-off-by: Gleb Natapov --- v1->v2 fix indentation remove unneeded ifdefs v2->v3 added needed ifdefs (CONFIG_KVM_PARA) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index