Re: [Qemu-devel] [PATCHv3] qemu-img rebase: use empty string to rebase without backing file

2012-10-16 Thread Alex Bligh
Kevin, --On 16 October 2012 13:22:47 +0200 Kevin Wolf wrote: Apart from the coding style problems, the patch looks good to me. Coding problems fixed & v4 sent under separate cover. -- Alex Bligh

Re: [Qemu-devel] [PATCHv3] qemu-img rebase: use empty string to rebase without backing file

2012-10-16 Thread Kevin Wolf
Am 15.10.2012 22:50, schrieb Alex Bligh: > This patch allows an empty filename to be passed as the new base image name > for qemu-img rebase to mean base the image on no backing file (i.e. > independent of any backing file). According to Eric Blake, qemu-img rebase > already supports this when '-u'

Re: [Qemu-devel] [PATCHv3] qemu-img rebase: use empty string to rebase without backing file

2012-10-15 Thread Eric Blake
On 10/15/2012 02:50 PM, Alex Bligh wrote: > This patch allows an empty filename to be passed as the new base image name > for qemu-img rebase to mean base the image on no backing file (i.e. > independent of any backing file). According to Eric Blake, qemu-img rebase > already supports this when '-u

[Qemu-devel] [PATCHv3] qemu-img rebase: use empty string to rebase without backing file

2012-10-15 Thread Alex Bligh
This patch allows an empty filename to be passed as the new base image name for qemu-img rebase to mean base the image on no backing file (i.e. independent of any backing file). According to Eric Blake, qemu-img rebase already supports this when '-u' is used; this adds support when -u is not used.