Re: [Qemu-devel] [PATCHv3 02/13] sparc32_dma: split esp and le into separate DMA devices

2017-10-27 Thread Philippe Mathieu-Daudé
On 10/20/2017 09:41 AM, Mark Cave-Ayland wrote: >>> -dev = qdev_create(NULL, "sparc32-dma-device"); >>> +dev = qdev_create(NULL, is_ledma ? "sparc32-ledma" : "sparc32-espdma"); >> >> TYPE_SPARC32_LEDMA_DEVICE and TYPE_SPARC32_ESPDMA_DEVICE? > > Again please note that this patch is an inter

Re: [Qemu-devel] [PATCHv3 02/13] sparc32_dma: split esp and le into separate DMA devices

2017-10-20 Thread Mark Cave-Ayland
On 19/10/17 05:33, Philippe Mathieu-Daudé wrote: > On 10/14/2017 03:38 PM, Mark Cave-Ayland wrote: >> Due to slight differences in behaviour accessing the registers for the >> esp and le devices, create two separate SPARC32_DMA_DEVICE types and >> update the sun4m machine to use. >> >> Note that

Re: [Qemu-devel] [PATCHv3 02/13] sparc32_dma: split esp and le into separate DMA devices

2017-10-18 Thread Philippe Mathieu-Daudé
On 10/14/2017 03:38 PM, Mark Cave-Ayland wrote: > Due to slight differences in behaviour accessing the registers for the > esp and le devices, create two separate SPARC32_DMA_DEVICE types and > update the sun4m machine to use. > > Note that by using different device types we already know the size

[Qemu-devel] [PATCHv3 02/13] sparc32_dma: split esp and le into separate DMA devices

2017-10-14 Thread Mark Cave-Ayland
Due to slight differences in behaviour accessing the registers for the esp and le devices, create two separate SPARC32_DMA_DEVICE types and update the sun4m machine to use. Note that by using different device types we already know the size of the register block and the value of is_ledma at init ti