Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-08 Thread Paolo Bonzini
Il 08/10/2013 14:05, Peter Lieven ha scritto: >> Strictly speaking, this should probably do something like this: >> >>assert(ret & BDRV_BLOCK_OFFSET_VALID); >>return bdrv_get_block_status(bs->file, ret >> BDRV_SECTOR_BITS, >> nb_sectors, pnum); > shouldn't th

Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-08 Thread Peter Lieven
On 07.10.2013 10:25, Paolo Bonzini wrote: Il 07/10/2013 07:59, Peter Lieven ha scritto: if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs->file. Signed-off-by: Peter Lieven --- v5: add a generic get_lba_

Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-08 Thread Stefan Hajnoczi
On Mon, Oct 7, 2013 at 10:25 AM, Paolo Bonzini wrote: > Il 07/10/2013 07:59, Peter Lieven ha scritto: >> if a raw device like an iscsi target or host device is used >> the current implementation makes a second call out to get >> the block status of bs->file. >> >> Signed-off-by: Peter Lieven >> -

Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-07 Thread Peter Lieven
On 07.10.2013 10:25, Paolo Bonzini wrote: Il 07/10/2013 07:59, Peter Lieven ha scritto: if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs->file. Signed-off-by: Peter Lieven --- v5: add a generic get_lba_

Re: [Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-07 Thread Paolo Bonzini
Il 07/10/2013 07:59, Peter Lieven ha scritto: > if a raw device like an iscsi target or host device is used > the current implementation makes a second call out to get > the block status of bs->file. > > Signed-off-by: Peter Lieven > --- > v5: add a generic get_lba_status function in the raw driv

[Qemu-devel] [PATCHv5] block/get_block_status: avoid redundant callouts on raw devices

2013-10-06 Thread Peter Lieven
if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs->file. Signed-off-by: Peter Lieven --- v5: add a generic get_lba_status function in the raw driver which adds the BDRV_BLOCK_RAW flag. bdrv_co_get_block