Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Anthony Liguori
On 01/03/2012 11:38 AM, Avi Kivity wrote: On 01/03/2012 07:16 PM, Avi Kivity wrote: On 01/03/2012 07:09 PM, Avi Kivity wrote: (strange, I was 100% sure I tested Xen). Ah, we have different CONFIG_XEN_CTRL_INTERFACE_VERSIONs. Updated branch pushed - changed the signature of an empty-bodied

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Avi Kivity
On 01/03/2012 07:16 PM, Avi Kivity wrote: > On 01/03/2012 07:09 PM, Avi Kivity wrote: > > (strange, I was 100% sure I tested Xen). > > > > Ah, we have different CONFIG_XEN_CTRL_INTERFACE_VERSIONs. > Updated branch pushed - changed the signature of an empty-bodied function, should be safe. git:/

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Avi Kivity
On 01/03/2012 07:09 PM, Avi Kivity wrote: > (strange, I was 100% sure I tested Xen). > Ah, we have different CONFIG_XEN_CTRL_INTERFACE_VERSIONs. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Avi Kivity
On 01/03/2012 07:06 PM, Anthony Liguori wrote: > On 12/27/2011 09:38 AM, Avi Kivity wrote: >> Changes since first posting: fold a fixup patch into its parent patch, >> style fixes. >> >> I didn't get much review or testing for vhost or Xen, due to various >> issues around births separated by a larg

Re: [Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2012-01-03 Thread Anthony Liguori
On 12/27/2011 09:38 AM, Avi Kivity wrote: Changes since first posting: fold a fixup patch into its parent patch, style fixes. I didn't get much review or testing for vhost or Xen, due to various issues around births separated by a large amount of time if not distance, but I don't want to get thi

[Qemu-devel] [PULL][v2] Remove cpu_get_physical_page_desc

2011-12-27 Thread Avi Kivity
Changes since first posting: fold a fixup patch into its parent patch, style fixes. I didn't get much review or testing for vhost or Xen, due to various issues around births separated by a large amount of time if not distance, but I don't want to get this series to get stale. Given that both are