Re: [Qemu-devel] [PULL] slirp: Fix access to freed memory

2016-11-15 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 09:20:29PM +0100, Samuel Thibault wrote: > The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: > > Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging > (2016-11-11 12:51:50 +) > > are available in the git repository at: >

Re: [Qemu-devel] [PULL] slirp: Fix access to freed memory

2016-11-14 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PULL] slirp: Fix access to freed memory Message-id: 20161114202030.17685-2-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

[Qemu-devel] [PULL] slirp: Fix access to freed memory

2016-11-14 Thread Samuel Thibault
The following changes since commit 83c83f9a5266ff113060f887f106a47920fa6974: Merge remote-tracking branch 'bonzini/tags/for-upstream' into staging (2016-11-11 12:51:50 +) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you t

[Qemu-devel] [PULL] slirp: Fix access to freed memory

2016-11-14 Thread Samuel Thibault
if_start() goes through the slirp->if_fastq and slirp->if_batchq list of pending messages, and accesses ifm->ifq_so->so_nqueued of its elements if ifm->ifq_so != NULL. When freeing a socket, we thus need to make sure that any pending message for this socket does not refer to the socket any more.