Re: [Qemu-devel] [PULL 0/4] tlb fixes for self-modifying code

2016-07-15 Thread Hulin, Patrick - 0559 - MITLL
Hi all, Just noticed this patch and wanted to leave a quick comment. The original issue wasn't with cross-page writes - it was with cross-TB writes. Cross-page writes become an issue once you reverse the order of the loop, so that part of the patch is necessary. But someone might want to leave

Re: [Qemu-devel] [PULL 0/4] tlb fixes for self-modifying code

2016-07-11 Thread Peter Maydell
On 8 July 2016 at 21:38, Richard Henderson wrote: > Synchronicity? Both changes look good to me. > > I took the opportunity to tidy up softmmu_template.h a tiny bit at > the same time, to avoid too much increase in code size in cold code > paths. The final is 4k smaller than the original. > > >

[Qemu-devel] [PULL 0/4] tlb fixes for self-modifying code

2016-07-08 Thread Richard Henderson
Synchronicity? Both changes look good to me. I took the opportunity to tidy up softmmu_template.h a tiny bit at the same time, to avoid too much increase in code size in cold code paths. The final is 4k smaller than the original. r~ The following changes since commit 4f4a9ca4a4386c137301b366