Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-15 Thread Peter Maydell
On Mon, 15 Jul 2019 at 15:04, Daniel P. Berrangé wrote: > MultiFDInit_t msg = {0}; > > should fix it. A minor nit, but "= {}" is our standard struct-zero-initializer so we should prefer that, I think. (I know it is not the C-spec recommended version but some C compilers incorrectly warn

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-15 Thread Peter Maydell
On Mon, 15 Jul 2019 at 15:10, Juan Quintela wrote: > PS. BTW, did you launched by hand the guests with valgrind, or there is > a trick that I am missing for launching a qtest with valgrind? I quoted the command line I used: QTEST_QEMU_BINARY='valgrind aarch64-softmmu/qemu-system-aarch64'

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-15 Thread Juan Quintela
Peter Maydell wrote: > On Mon, 15 Jul 2019 at 14:44, Juan Quintela wrote: >> >> Peter Maydell wrote: >> > On Fri, 12 Jul 2019 at 17:33, Peter Maydell >> > wrote: >> >> Still fails on aarch32 host, I'm afraid: >> >> Hi >> >> dropping the multifd test patch from now. For "some" reason, having

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-15 Thread Daniel P . Berrangé
On Mon, Jul 15, 2019 at 12:16:57PM +0100, Peter Maydell wrote: > On Fri, 12 Jul 2019 at 17:33, Peter Maydell wrote: > > Still fails on aarch32 host, I'm afraid: > > > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > > QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 > >

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-15 Thread Peter Maydell
On Mon, 15 Jul 2019 at 14:44, Juan Quintela wrote: > > Peter Maydell wrote: > > On Fri, 12 Jul 2019 at 17:33, Peter Maydell > > wrote: > >> Still fails on aarch32 host, I'm afraid: > > Hi > > dropping the multifd test patch from now. For "some" reason, having a > packed struct and 32bits is

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-15 Thread Juan Quintela
Peter Maydell wrote: > On Fri, 12 Jul 2019 at 17:33, Peter Maydell wrote: >> Still fails on aarch32 host, I'm afraid: Hi dropping the multifd test patch from now. For "some" reason, having a packed struct and 32bits is getting ugly, not sure yet _why_. Resending the pull request. >> >>

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-15 Thread Peter Maydell
On Fri, 12 Jul 2019 at 17:33, Peter Maydell wrote: > Still fails on aarch32 host, I'm afraid: > > MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} > QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 > QTEST_QEMU_IMG=qemu-img tests/migration-test -m=quick -k --tap < > /dev/null

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Fri, 12 Jul 2019 at 15:32, Juan Quintela wrote: > > > > The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: > > > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' > > into staging

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread Peter Maydell
On Fri, 12 Jul 2019 at 15:32, Juan Quintela wrote: > > The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' > into staging (2019-07-12 11:06:48 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190711104412.31233-1-quint...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190711104412.31233-1-quint...@redhat.com Type: series Subject: [Qemu-devel] [PULL 00/19] Migration

[Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread Juan Quintela
The following changes since commit a2a9d4adabe340617a24eb73a8b2a116d28a6b38: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.1-20190712' into staging (2019-07-12 11:06:48 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-12 Thread Juan Quintela
Peter Maydell wrote: > On Thu, 11 Jul 2019 at 11:56, Juan Quintela wrote: >> >> The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: >> >> Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) >> >> are available in the Git repository at: >> >>

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190711104412.31233-1-quint...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190711104412.31233-1-quint...@redhat.com Type: series Subject: [Qemu-devel] [PULL 00/19] Migration

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Peter Maydell
On Thu, 11 Jul 2019 at 13:56, Christian Borntraeger wrote: > > > > On 11.07.19 12:43, Juan Quintela wrote: > > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > > > are available in the Git

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Christian Borntraeger
On 11.07.19 12:43, Juan Quintela wrote: > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > are available in the Git repository at: > > https://github.com/juanquintela/qemu.git

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Peter Maydell
On Thu, 11 Jul 2019 at 11:56, Juan Quintela wrote: > > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > are available in the Git repository at: > > https://github.com/juanquintela/qemu.git

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Peter Maydell
On Thu, 11 Jul 2019 at 12:34, Dr. David Alan Gilbert wrote: > > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 11/07/19 12:43, Juan Quintela wrote: > > > The following changes since commit > > > 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > > > > > Update version for v4.1.0-rc0 release

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 11/07/19 12:43, Juan Quintela wrote: > > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > > > are available in the Git repository at: > >

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Juan Quintela
Paolo Bonzini wrote: > On 11/07/19 12:43, Juan Quintela wrote: >> The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: >> >> Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) >> >> are available in the Git repository at: >> >>

Re: [Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Paolo Bonzini
On 11/07/19 12:43, Juan Quintela wrote: > The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: > > Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) > > are available in the Git repository at: > > https://github.com/juanquintela/qemu.git

[Qemu-devel] [PULL 00/19] Migration patches

2019-07-11 Thread Juan Quintela
The following changes since commit 6df2cdf44a82426f7a59dcb03f0dd2181ed7fdfa: Update version for v4.1.0-rc0 release (2019-07-09 17:21:53 +0100) are available in the Git repository at: https://github.com/juanquintela/qemu.git tags/migration-pull-request for you to fetch changes up to