Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-07-21 Thread Michael Roth
Quoting Peter Maydell (2015-07-21 06:42:41) > On 5 June 2015 at 16:20, Paolo Bonzini wrote: > > On 05/06/2015 17:08, Peter Maydell wrote: > >>> > Can someone add a checkpatch rule that forbids shifting left U or UL > >>> > constants (i.e. only ULL)? That would alleviate my concerns with these > >

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-07-21 Thread Peter Maydell
On 5 June 2015 at 16:20, Paolo Bonzini wrote: > On 05/06/2015 17:08, Peter Maydell wrote: >>> > Can someone add a checkpatch rule that forbids shifting left U or UL >>> > constants (i.e. only ULL)? That would alleviate my concerns with these >>> > ubsan warnings. >> >> ...but things like "(1U <<

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-05 Thread Peter Maydell
On 5 June 2015 at 16:20, Paolo Bonzini wrote: > > > On 05/06/2015 17:08, Peter Maydell wrote: >>> > Can someone add a checkpatch rule that forbids shifting left U or UL >>> > constants (i.e. only ULL)? That would alleviate my concerns with these >>> > ubsan warnings. >> >> ...but things like "(1U

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-05 Thread Eric Blake
On 06/05/2015 07:33 AM, Peter Maydell wrote: > On 3 June 2015 at 22:45, Alexander Graf wrote: >> Hi Peter, >> >> This is my current patch queue for ppc. Please pull. > > This is applied, but can you fix the clang sanitizer warnings, > please? > > hw/ppc/spapr_drc.c:59:24: runtime error: left sh

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-05 Thread Paolo Bonzini
On 05/06/2015 17:08, Peter Maydell wrote: >> > Can someone add a checkpatch rule that forbids shifting left U or UL >> > constants (i.e. only ULL)? That would alleviate my concerns with these >> > ubsan warnings. > > ...but things like "(1U << 31)" are entirely valid. They're only valid until s

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-05 Thread Peter Maydell
On 5 June 2015 at 16:02, Paolo Bonzini wrote: > > > On 05/06/2015 16:40, Peter Maydell wrote: >> > Speaking in general, I find that this makes code worse. If you're using >> > ~0 you probably want the value to extend with infinite ones. >> > >> > Using ~0u instead of ~0ull may cause problems down

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-05 Thread Paolo Bonzini
On 05/06/2015 16:40, Peter Maydell wrote: > > Speaking in general, I find that this makes code worse. If you're using > > ~0 you probably want the value to extend with infinite ones. > > > > Using ~0u instead of ~0ull may cause problems down the line, and ~0ul > > is even worse because it is no

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-05 Thread Peter Maydell
On 5 June 2015 at 15:35, Paolo Bonzini wrote: > > > On 05/06/2015 15:33, Peter Maydell wrote: >> This is applied, but can you fix the clang sanitizer warnings, >> please? >> >> hw/ppc/spapr_drc.c:59:24: runtime error: left shift of negative value -1 >> hw/ppc/spapr_drc.c:587:19: runtime error: lef

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-05 Thread Paolo Bonzini
On 05/06/2015 15:33, Peter Maydell wrote: > This is applied, but can you fix the clang sanitizer warnings, > please? > > hw/ppc/spapr_drc.c:59:24: runtime error: left shift of negative value -1 > hw/ppc/spapr_drc.c:587:19: runtime error: left shift of negative value -1 > > Problem looks to be i

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-05 Thread Peter Maydell
On 3 June 2015 at 22:45, Alexander Graf wrote: > Hi Peter, > > This is my current patch queue for ppc. Please pull. This is applied, but can you fix the clang sanitizer warnings, please? hw/ppc/spapr_drc.c:59:24: runtime error: left shift of negative value -1 hw/ppc/spapr_drc.c:587:19: runtime

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-04 Thread Peter Maydell
On 3 June 2015 at 22:45, Alexander Graf wrote: > Hi Peter, > > This is my current patch queue for ppc. Please pull. > > Alex > > > The following changes since commit 3fc827d591679f3e262b9d1f8b34528eabfca8c0: > > target-arm: Correct check for non-EL3 (2015-06-02 13:22:29 +0100) > > are available

[Qemu-devel] [PULL 00/40] ppc patch queue 2015-06-03

2015-06-03 Thread Alexander Graf
Hi Peter, This is my current patch queue for ppc. Please pull. Alex The following changes since commit 3fc827d591679f3e262b9d1f8b34528eabfca8c0: target-arm: Correct check for non-EL3 (2015-06-02 13:22:29 +0100) are available in the git repository at: git://github.com/agraf/qemu.git tags