Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 05:51:28PM +0300, Michael S. Tsirkin wrote: > On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: > > Please put together a summary of the testing this series has gone > > through. I still think there should be automated testing as part of > > this but if the m

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Igor Mammedov
On Tue, 15 Oct 2013 17:51:28 +0300 "Michael S. Tsirkin" wrote: > On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: > > Please put together a summary of the testing this series has gone > > through. I still think there should be automated testing as part of > > this but if the manu

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: > Please put together a summary of the testing this series has gone > through. I still think there should be automated testing as part of > this but if the manual testing is sufficiently thorough I'll > reconsider for 1.7. > > Regar

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: > I cannot reasonable revert a series like this before we cut GA. It's very simple actually. Here's a patch to disable it all. diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 63ae2ae..1a5a70c 100644 --- a/hw/i386/pc_piix.c

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: > On Tue, Oct 15, 2013 at 7:20 AM, Michael S. Tsirkin wrote: > > On Tue, Oct 15, 2013 at 06:51:30AM -0700, Anthony Liguori wrote: > >> On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin > >> wrote: > >> > On Mon, Oct 14, 2013 at

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 07:17:59AM -0700, Anthony Liguori wrote: > On Tue, Oct 15, 2013 at 7:01 AM, Paolo Bonzini wrote: > > Il 15/10/2013 15:51, Anthony Liguori ha scritto: > >> From 41/43: > >> > >> "The interface is actually backwards-compatible with > >> existing PIIX4 ACPI (though not migrat

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Anthony Liguori
On Tue, Oct 15, 2013 at 7:20 AM, Michael S. Tsirkin wrote: > On Tue, Oct 15, 2013 at 06:51:30AM -0700, Anthony Liguori wrote: >> On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin wrote: >> > On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: >> >> "Michael S. Tsirkin" writes: >>

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 06:53:54AM -0700, Anthony Liguori wrote: > On Tue, Oct 15, 2013 at 6:43 AM, Gerd Hoffmann wrote: > > On Mo, 2013-10-14 at 15:42 -0700, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > Anthony, I know you wanted to review some of the patches, > >> > sinc

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Anthony Liguori
On Tue, Oct 15, 2013 at 7:01 AM, Paolo Bonzini wrote: > Il 15/10/2013 15:51, Anthony Liguori ha scritto: >> From 41/43: >> >> "The interface is actually backwards-compatible with >> existing PIIX4 ACPI (though not migration compatible)." >> >> And does "AFAIK" translate to, "I have tested migrati

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 06:51:30AM -0700, Anthony Liguori wrote: > On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin wrote: > > On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > Anthony, I know you wanted to review some of the patche

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Gerd Hoffmann
On Mo, 2013-10-14 at 15:42 -0700, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > Anthony, I know you wanted to review some of the patches, > > since you didn't respond either all's well or you > > could not find the time. > > I think we are better off merging them for 1.7 and then -

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Igor Mammedov
On Tue, 15 Oct 2013 06:51:30 -0700 Anthony Liguori wrote: > On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin wrote: > > On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > Anthony, I know you wanted to review some of the patches, >

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 15:51, Anthony Liguori ha scritto: > From 41/43: > > "The interface is actually backwards-compatible with > existing PIIX4 ACPI (though not migration compatible)." > > And does "AFAIK" translate to, "I have tested migration from new and > old and old and new with this series"? I s

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Anthony Liguori
On Tue, Oct 15, 2013 at 6:43 AM, Gerd Hoffmann wrote: > On Mo, 2013-10-14 at 15:42 -0700, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > Anthony, I know you wanted to review some of the patches, >> > since you didn't respond either all's well or you >> > could not find the time. >

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Anthony Liguori
On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin wrote: > On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > Anthony, I know you wanted to review some of the patches, >> > since you didn't respond either all's well or you >> > could not fi

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Gerd Hoffmann
On Mo, 2013-10-14 at 15:42 -0700, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > Anthony, I know you wanted to review some of the patches, > > since you didn't respond either all's well or you > > could not find the time. > > I think we are better off merging them for 1.7 and then -

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Igor Mammedov
On Mon, 14 Oct 2013 15:42:37 -0700 Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > Anthony, I know you wanted to review some of the patches, > > since you didn't respond either all's well or you > > could not find the time. > > I think we are better off merging them for 1.7 and then

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: > This is a huge series and I still am not convinced this is the right > path forward. Also, this kind of response is quite unexpected after this direction was discussed multiple times and largely agreed upon on the phone meeting, an

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > Anthony, I know you wanted to review some of the patches, > > since you didn't respond either all's well or you > > could not find the time. > > I think we are better off merging them for 1.7 and

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > Anthony, I know you wanted to review some of the patches, > since you didn't respond either all's well or you > could not find the time. > I think we are better off merging them for 1.7 and then - worst case, > if major issues surface - disabling the functionality a

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Paolo Bonzini
Il 14/10/2013 17:12, Michael S. Tsirkin ha scritto: > > Are you going to do another pull request with the virtio and bus-reset > > fixes? > > I missed that you did the testing of the post-order changed. > I'll put them on my branch but I'd rather this kind of > change went through a bit more testi

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 04:57:19PM +0200, Paolo Bonzini wrote: > Il 14/10/2013 16:57, Michael S. Tsirkin ha scritto: > > pci, pc, acpi fixes, enhancements > > > > This includes some pretty big changes: > > - pci master abort support by Marcel > > - pci IRQ API rework by Marcel > > - acpi generatio

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Paolo Bonzini
Il 14/10/2013 16:57, Michael S. Tsirkin ha scritto: > pci, pc, acpi fixes, enhancements > > This includes some pretty big changes: > - pci master abort support by Marcel > - pci IRQ API rework by Marcel > - acpi generation and pci bridge hotplug support by myself > > Everything has gone through s

[Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Michael S. Tsirkin
Anthony, I know you wanted to review some of the patches, since you didn't respond either all's well or you could not find the time. I think we are better off merging them for 1.7 and then - worst case, if major issues surface - disabling the functionality at the last minute than delaying the merge