Re: [Qemu-devel] [PULL 02/33] qapi: Clean up cgen() and mcgen()

2015-09-07 Thread Markus Armbruster
Laurent Desnogues writes: > Hello Markus, > > I found some Python issue with this commit. > > On Fri, Sep 4, 2015 at 4:21 PM, Markus Armbruster wrote: >> Commit 05dfb26 added eatspace stripping to mcgen(). Move it to >> cgen(), just in case somebody gets tempted to use cgen() directly >> instea

Re: [Qemu-devel] [PULL 02/33] qapi: Clean up cgen() and mcgen()

2015-09-07 Thread Laurent Desnogues
Hello Markus, I found some Python issue with this commit. On Fri, Sep 4, 2015 at 4:21 PM, Markus Armbruster wrote: > Commit 05dfb26 added eatspace stripping to mcgen(). Move it to > cgen(), just in case somebody gets tempted to use cgen() directly > instead of via mcgen(). > > cgen() indents bl

[Qemu-devel] [PULL 02/33] qapi: Clean up cgen() and mcgen()

2015-09-04 Thread Markus Armbruster
Commit 05dfb26 added eatspace stripping to mcgen(). Move it to cgen(), just in case somebody gets tempted to use cgen() directly instead of via mcgen(). cgen() indents blank lines. No such lines get generated right now, but fix it anyway. We use triple-quoted strings for program text, like this