Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-08 Thread Philippe Mathieu-Daudé
On Thu, Nov 8, 2018 at 3:30 PM Laurent Vivier wrote: > On 08/11/2018 11:24, Stefan Hajnoczi wrote: > > On Tue, Nov 06, 2018 at 05:16:14PM +0100, Laurent Vivier wrote: > >> On 06/11/2018 16:15, Philippe Mathieu-Daudé wrote: > >>> On 6/11/18 15:13, Michael S. Tsirkin wrote: > On Tue, Nov 06, 20

Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-08 Thread Laurent Vivier
On 08/11/2018 11:24, Stefan Hajnoczi wrote: > On Tue, Nov 06, 2018 at 05:16:14PM +0100, Laurent Vivier wrote: >> On 06/11/2018 16:15, Philippe Mathieu-Daudé wrote: >>> On 6/11/18 15:13, Michael S. Tsirkin wrote: On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote: > On 5

Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-08 Thread Stefan Hajnoczi
On Tue, Nov 06, 2018 at 05:16:14PM +0100, Laurent Vivier wrote: > On 06/11/2018 16:15, Philippe Mathieu-Daudé wrote: > > On 6/11/18 15:13, Michael S. Tsirkin wrote: > >> On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote: > >>> On 5/11/18 19:14, Michael S. Tsirkin wrote: >

Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-06 Thread Laurent Vivier
On 06/11/2018 16:15, Philippe Mathieu-Daudé wrote: > On 6/11/18 15:13, Michael S. Tsirkin wrote: >> On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote: >>> On 5/11/18 19:14, Michael S. Tsirkin wrote: From: Peter Maydell Currently tests/hex-loader-check-data conta

Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-06 Thread Michael S. Tsirkin
On Tue, Nov 06, 2018 at 04:15:03PM +0100, Philippe Mathieu-Daudé wrote: > On 6/11/18 15:13, Michael S. Tsirkin wrote: > > On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote: > > > On 5/11/18 19:14, Michael S. Tsirkin wrote: > > > > From: Peter Maydell > > > > > > > > Currently

Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-06 Thread Michael S. Tsirkin
On Tue, Nov 06, 2018 at 03:31:08PM +, Peter Maydell wrote: > On 6 November 2018 at 15:15, Philippe Mathieu-Daudé wrote: > > No worry, I'm not mad at all, but there might be an issue in your git PR > > workflow, this series also missed your maintainer S-o-b. > > > > Peter: Can you add a such ch

Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-06 Thread Peter Maydell
On 6 November 2018 at 15:15, Philippe Mathieu-Daudé wrote: > No worry, I'm not mad at all, but there might be an issue in your git PR > workflow, this series also missed your maintainer S-o-b. > > Peter: Can you add a such check in your scripts? (during next merge window, > no hurry). > > Rather t

Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-06 Thread Philippe Mathieu-Daudé
On 6/11/18 15:13, Michael S. Tsirkin wrote: On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote: On 5/11/18 19:14, Michael S. Tsirkin wrote: From: Peter Maydell Currently tests/hex-loader-check-data contains data files used by the hexloader-test, and configure individually

Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-06 Thread Michael S. Tsirkin
On Tue, Nov 06, 2018 at 02:27:18PM +0100, Philippe Mathieu-Daudé wrote: > On 5/11/18 19:14, Michael S. Tsirkin wrote: > > From: Peter Maydell > > > > Currently tests/hex-loader-check-data contains data files used > > by the hexloader-test, and configure individually symlinks those > > data files

Re: [Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-06 Thread Philippe Mathieu-Daudé
On 5/11/18 19:14, Michael S. Tsirkin wrote: From: Peter Maydell Currently tests/hex-loader-check-data contains data files used by the hexloader-test, and configure individually symlinks those data files into the build directory using a wildcard. Using a wildcard like this is a bad idea, becaus

[Qemu-devel] [PULL 02/33] tests: Move tests/hex-loader-check-data/ to tests/data/hex-loader/

2018-11-05 Thread Michael S. Tsirkin
From: Peter Maydell Currently tests/hex-loader-check-data contains data files used by the hexloader-test, and configure individually symlinks those data files into the build directory using a wildcard. Using a wildcard like this is a bad idea, because if a new data file is added, nothing causes