Re: [Qemu-devel] [PULL 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi

2019-05-30 Thread Peter Maydell
On Thu, 30 May 2019 at 13:35, Alex Bennée wrote: > > > Peter Maydell writes: > > > Also it looks a bit dodgy that we are passed in a > > specific length value but we then go and look at the length > > of the string, but we trust the specific length value over > > the length of the string. If len

Re: [Qemu-devel] [PULL 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi

2019-05-30 Thread Alex Bennée
Peter Maydell writes: > On Tue, 28 May 2019 at 10:49, Alex Bennée wrote: >> >> Now we have a common semihosting console interface use that for our >> string output. However ARM is currently unique in also supporting >> semihosting for linux-user so we need to replicate the API in >> linux-user

Re: [Qemu-devel] [PULL 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi

2019-05-30 Thread Peter Maydell
On Tue, 28 May 2019 at 10:49, Alex Bennée wrote: > > Now we have a common semihosting console interface use that for our > string output. However ARM is currently unique in also supporting > semihosting for linux-user so we need to replicate the API in > linux-user. If other architectures gain thi

[Qemu-devel] [PULL 06/28] target/arm: use the common interface for WRITE0/WRITEC in arm-semi

2019-05-28 Thread Alex Bennée
Now we have a common semihosting console interface use that for our string output. However ARM is currently unique in also supporting semihosting for linux-user so we need to replicate the API in linux-user. If other architectures gain this support we can move the file later. Signed-off-by: Alex B