Re: [Qemu-devel] [PULL 08/15] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-05-22 Thread Laszlo Ersek
On 05/22/18 14:44, Cornelia Huck wrote: > On Tue, 15 May 2018 10:45:02 +0200 > Laszlo Ersek wrote: > >> I've come across this patch in downstream review (although I really have >> zero background in s390x), and Cornelia suggested I might want to repeat >> my comments on the

Re: [Qemu-devel] [PULL 08/15] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-05-22 Thread Collin Walling
On 05/22/2018 08:44 AM, Cornelia Huck wrote: > On Tue, 15 May 2018 10:45:02 +0200 > Laszlo Ersek wrote: > >> I've come across this patch in downstream review (although I really have >> zero background in s390x), and Cornelia suggested I might want to repeat >> my comments on

Re: [Qemu-devel] [PULL 08/15] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-05-22 Thread Cornelia Huck
On Tue, 15 May 2018 10:45:02 +0200 Laszlo Ersek wrote: > I've come across this patch in downstream review (although I really have > zero background in s390x), and Cornelia suggested I might want to repeat > my comments on the upstream list too: > > On 05/04/18 09:25, Cornelia

Re: [Qemu-devel] [PULL 08/15] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-05-15 Thread Laszlo Ersek
I've come across this patch in downstream review (although I really have zero background in s390x), and Cornelia suggested I might want to repeat my comments on the upstream list too: On 05/04/18 09:25, Cornelia Huck wrote: > From: Collin Walling > > Rename the loadparm

[Qemu-devel] [PULL 08/15] pc-bios/s390-ccw: fix loadparm initialization and int conversion

2018-05-04 Thread Cornelia Huck
From: Collin Walling Rename the loadparm char array in main.c to loadparm_str and increased the size by one byte to account for a null termination when converting the loadparm string to an int via atoui. We also allow the boot menu to be enabled when loadparm is set to an