Re: [Qemu-devel] [PULL 08/51] chardev: introduce qemu_chr_timeout_add_ms()

2018-01-17 Thread Peter Xu
On Wed, Jan 17, 2018 at 05:21:40PM +0100, Marc-André Lureau wrote: > Hi > > On Tue, Jan 16, 2018 at 3:16 PM, Paolo Bonzini wrote: > > From: Peter Xu > > > > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > > now can have dedicated

Re: [Qemu-devel] [PULL 08/51] chardev: introduce qemu_chr_timeout_add_ms()

2018-01-17 Thread Marc-André Lureau
Hi On Tue, Jan 16, 2018 at 3:16 PM, Paolo Bonzini wrote: > From: Peter Xu > > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > now can have dedicated gcontext, we should always bind chardev tasks > onto those gcontext rather than

Re: [Qemu-devel] [PULL 08/51] chardev: introduce qemu_chr_timeout_add_ms()

2018-01-16 Thread Paolo Bonzini
On 16/01/2018 15:43, Daniel P. Berrange wrote: >> >> It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs >> now can have dedicated gcontext, we should always bind chardev tasks >> onto those gcontext rather than the default main context. Since there >> are quite a few of

Re: [Qemu-devel] [PULL 08/51] chardev: introduce qemu_chr_timeout_add_ms()

2018-01-16 Thread Daniel P. Berrange
On Tue, Jan 16, 2018 at 03:16:50PM +0100, Paolo Bonzini wrote: > From: Peter Xu > > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > now can have dedicated gcontext, we should always bind chardev tasks > onto those gcontext rather than the default main

[Qemu-devel] [PULL 08/51] chardev: introduce qemu_chr_timeout_add_ms()

2018-01-16 Thread Paolo Bonzini
From: Peter Xu It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs now can have dedicated gcontext, we should always bind chardev tasks onto those gcontext rather than the default main context. Since there are quite a few of g_timeout_add[_seconds]()