Re: [Qemu-devel] [PULL 1/1] slirp: fix clearing ifq_so from pending packets

2017-08-28 Thread Samuel Thibault
Samuel Thibault, on lun. 28 août 2017 17:44:55 +0200, wrote: > Eric Blake, on lun. 28 août 2017 10:43:48 -0500, wrote: > > This is a pull request, but missed 2.10-rc4, which makes it really hard > > to justify for inclusion in 2.10 proper. Is it okay that this doesn't > > go in until 2.11? > > We

Re: [Qemu-devel] [PULL 1/1] slirp: fix clearing ifq_so from pending packets

2017-08-28 Thread Samuel Thibault
Hello, Eric Blake, on lun. 28 août 2017 10:43:48 -0500, wrote: > This is a pull request, but missed 2.10-rc4, which makes it really hard > to justify for inclusion in 2.10 proper. Is it okay that this doesn't > go in until 2.11? Well, AIUI we have been living with the issue for years (decades?),

Re: [Qemu-devel] [PULL 1/1] slirp: fix clearing ifq_so from pending packets

2017-08-28 Thread Eric Blake
On 08/27/2017 06:05 PM, Samuel Thibault wrote: > The if_fastq and if_batchq contain not only packets, but queues of packets > for the same socket. When sofree frees a socket, it thus has to clear ifq_so > from all the packets from the queues, not only the first. > > Signed-off-by: Samuel Thibault

[Qemu-devel] [PULL 1/1] slirp: fix clearing ifq_so from pending packets

2017-08-27 Thread Samuel Thibault
The if_fastq and if_batchq contain not only packets, but queues of packets for the same socket. When sofree frees a socket, it thus has to clear ifq_so from all the packets from the queues, not only the first. Signed-off-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- slirp/socket.c