Re: [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-05 Thread Frediano Ziglio
> Hi, > > > > vga->con = graphic_console_init(DEVICE(dev), 0, _ops, qxl); > > > +qxl->id = qemu_console_get_index(vga->con); /* == channel_id */ > > > +if (qxl->id != 0) { > > > +error_setg(errp, "primary qxl-vga device must be console 0 " > > > + "(first

Re: [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-05 Thread Gerd Hoffmann
Hi, > > vga->con = graphic_console_init(DEVICE(dev), 0, _ops, qxl); > > +qxl->id = qemu_console_get_index(vga->con); /* == channel_id */ > > +if (qxl->id != 0) { > > +error_setg(errp, "primary qxl-vga device must be console 0 " > > + "(first display device

Re: [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-05 Thread Frediano Ziglio
> > Hi, > > > > vga->con = graphic_console_init(DEVICE(dev), 0, _ops, qxl); > > > +qxl->id = qemu_console_get_index(vga->con); /* == channel_id */ > > > +if (qxl->id != 0) { > > > +error_setg(errp, "primary qxl-vga device must be console 0 " > > > + "(first

Re: [Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-11-02 Thread Frediano Ziglio
> > See qemu_spice_add_display_interface(), the console index is also used > as channel id. So put that into the qxl->id field too. > > In typical use cases (one primary qxl-vga device, optionally one or more > secondary qxl devices, no non-qxl display devices) this doesn't change > anything. >

[Qemu-devel] [PULL 1/2] qxl: store channel id in qxl->id

2018-10-29 Thread Gerd Hoffmann
See qemu_spice_add_display_interface(), the console index is also used as channel id. So put that into the qxl->id field too. In typical use cases (one primary qxl-vga device, optionally one or more secondary qxl devices, no non-qxl display devices) this doesn't change anything. With this in