Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread David Hildenbrand
On 12.02.19 13:08, Philippe Mathieu-Daudé wrote: > Hi David, > > On 2/12/19 12:47 PM, David Hildenbrand wrote: >> On 24.01.19 14:20, Gerd Hoffmann wrote: >>> Get rid of the pcspk_state global, allow pc speaker >>> be added using "-device isa-pcspk". >>> >>> Signed-off-by: Gerd Hoffmann >>> Review

Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread David Hildenbrand
On 12.02.19 13:20, David Hildenbrand wrote: > On 12.02.19 13:08, Philippe Mathieu-Daudé wrote: >> Hi David, >> >> On 2/12/19 12:47 PM, David Hildenbrand wrote: >>> On 24.01.19 14:20, Gerd Hoffmann wrote: Get rid of the pcspk_state global, allow pc speaker be added using "-device isa-pcspk

Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread Philippe Mathieu-Daudé
Hi David, On 2/12/19 12:47 PM, David Hildenbrand wrote: > On 24.01.19 14:20, Gerd Hoffmann wrote: >> Get rid of the pcspk_state global, allow pc speaker >> be added using "-device isa-pcspk". >> >> Signed-off-by: Gerd Hoffmann >> Reviewed-by: Philippe Mathieu-Daudé >> Message-id: 20190124110810.

Re: [Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-02-12 Thread David Hildenbrand
On 24.01.19 14:20, Gerd Hoffmann wrote: > Get rid of the pcspk_state global, allow pc speaker > be added using "-device isa-pcspk". > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Philippe Mathieu-Daudé > Message-id: 20190124110810.1040-1-kra...@redhat.com > --- > hw/audio/pcspk.c | 35

[Qemu-devel] [PULL 1/7] audio: fix pc speaker init

2019-01-24 Thread Gerd Hoffmann
Get rid of the pcspk_state global, allow pc speaker be added using "-device isa-pcspk". Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190124110810.1040-1-kra...@redhat.com --- hw/audio/pcspk.c | 35 +++ 1 file changed, 15 insertio