Re: [Qemu-devel] [PULL 1/9] hw/acpi-build: Make assignment statement of next_base easy to read

2017-11-28 Thread Dou Liyang
Hi, Igor, At 11/28/2017 11:07 PM, Igor Mammedov wrote: On Thu, 5 Oct 2017 17:36:30 -0300 Eduardo Habkost wrote: From: Dou Liyang It may be hard to read the assignment statement of "next_base", so S/next_base += (1ULL << 32) - pcms->below_4g_mem_size; /next_base = mem_base + mem_len; ...

Re: [Qemu-devel] [PULL 1/9] hw/acpi-build: Make assignment statement of next_base easy to read

2017-11-28 Thread Igor Mammedov
On Thu, 5 Oct 2017 17:36:30 -0300 Eduardo Habkost wrote: > From: Dou Liyang > > It may be hard to read the assignment statement of "next_base", so > > S/next_base += (1ULL << 32) - pcms->below_4g_mem_size; > /next_base = mem_base + mem_len; > > ... for readability. > > No functionality cha

[Qemu-devel] [PULL 1/9] hw/acpi-build: Make assignment statement of next_base easy to read

2017-10-05 Thread Eduardo Habkost
From: Dou Liyang It may be hard to read the assignment statement of "next_base", so S/next_base += (1ULL << 32) - pcms->below_4g_mem_size; /next_base = mem_base + mem_len; ... for readability. No functionality change. Signed-off-by: Dou Liyang Message-Id: <1504231805-30957-3-git-send-email-