Re: [Qemu-devel] [PULL 12/12] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation

2014-09-16 Thread Michael S. Tsirkin
On Sun, Sep 14, 2014 at 09:41:56PM +0300, Michael S. Tsirkin wrote: > From: Damjan Marion > > Header length check should happen only if backend is kernel. For user > backend there is no reason to reset this bit. > > vhost-user code does not define .has_vnet_hdr_len so > VIRTIO_NET_F_MRG_RXBUF ca

Re: [Qemu-devel] [PULL 12/12] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation

2014-09-16 Thread Linhaifeng
On 2014/9/15 2:41, Michael S. Tsirkin wrote: > From: Damjan Marion > > Header length check should happen only if backend is kernel. For user > backend there is no reason to reset this bit. > > vhost-user code does not define .has_vnet_hdr_len so > VIRTIO_NET_F_MRG_RXBUF cannot be negotiated ev

[Qemu-devel] [PULL 12/12] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation

2014-09-14 Thread Michael S. Tsirkin
From: Damjan Marion Header length check should happen only if backend is kernel. For user backend there is no reason to reset this bit. vhost-user code does not define .has_vnet_hdr_len so VIRTIO_NET_F_MRG_RXBUF cannot be negotiated even if both sides support it. Signed-off-by: Damjan Marion R