Re: [Qemu-devel] [PULL 12/25] vhost: use a function for each call

2015-10-09 Thread Thibaut Collet
On Thu, Oct 8, 2015 at 11:17 PM, Michael S. Tsirkin wrote: > From: Marc-André Lureau > > Replace the generic vhost_call() by specific functions for each > function call to help with type safety and changing arguments. > > While doing this, I found that "unsigned long long" and "uint64_t" were > u

Re: [Qemu-devel] [PULL 12/25] vhost: use a function for each call

2015-10-09 Thread Michael S. Tsirkin
On Fri, Oct 09, 2015 at 08:40:27AM +0200, Thibaut Collet wrote: > Hi Michael, > > this patch is not correct. If we apply QEMU enters in a dead lock if > we have several queue pairs for virttio/vhost and vhost backend > crashes during the initialisation sequence > I have sent some comments yesterda

[Qemu-devel] [PULL 12/25] vhost: use a function for each call

2015-10-08 Thread Michael S. Tsirkin
From: Marc-André Lureau Replace the generic vhost_call() by specific functions for each function call to help with type safety and changing arguments. While doing this, I found that "unsigned long long" and "uint64_t" were used interchangeably and causing compilation warnings, using uint64_t ins